search

dokku / ansible-dokku

Ansible modules for installing and configuring Dokku
MIT License
169 stars 44 forks source link

feat: dokku_image library #126

Closed fr3fou closed 2 years ago

fr3fou commented 2 years ago

This PR adds support for the git:from-image command for deploying Docker images. Closes #124

josegonzalez commented 2 years ago

@ltalirz please squash when merging this MR as it had some formatting-related changes that make git blame awkward.

ltalirz commented 2 years ago

The verify stage failed - I think you missed replacing one of the data arguments to dokku_git_sha in dokku_clone

ltalirz commented 2 years ago

There's also one of the ansible lint rules you may want to fix (the mkdir in the verify.yml)

ltalirz commented 2 years ago

For the remaining rules, it looks like - for whatever reason - ansible-lint is no longer respecting the our .ansible-lint configuration file (which is weird, since the version is locked down).

Anyhow, I will ignore those rules "manually" and merge the PR once the tests pass.

fr3fou commented 2 years ago

The verify stage failed - I think you missed replacing one of the data arguments to dokku_git_sha in dokku_clone

Both calls look fine to me? Am I missing something else?