search

dokku / ansible-dokku

Ansible modules for installing and configuring Dokku
MIT License
169 stars 44 forks source link

Fix reading existing dokku docker options #146

Closed erikvdv1 closed 1 year ago

erikvdv1 commented 1 year ago

The command dokku --quiet docker-options {app} no longer exists, use dokku --quiet docker-options:report {app} instead.

$ dokku --quiet docker-options:report {app}
       Docker options build:          --pull --build-arg test
       Docker options deploy:         --restart=on-failure:10
       Docker options run:

Unfortunately the report command outputs the options on a single line for each type (build, deploy, run). The options type is therefore a string instead of a list.

ltalirz commented 1 year ago

Hey Erik, just wanted to say thanks for all your contributions; I will try to find some time over the weekend to review them

ltalirz commented 1 year ago

The command dokku --quiet docker-options {app} no longer exists, use dokku --quiet docker-options:report {app} instead.

@josegonzalez Do you happen to know when this change was made? Just so that we can report the minimal dokku version the role is compatible with.

josegonzalez commented 1 year ago

This was changed in 0.20.0: https://dokku.com/docs/appendices/0.20.0-migration-guide/

ltalirz commented 1 year ago

P.S. Just fixed CI https://github.com/dokku/ansible-dokku/pull/147

erikvdv1 commented 1 year ago

You code looks good to me - since I currently don't have a machine to test, would you mind adding a small test somewhere around here

I've added a simple test. 😊