search

dokku / ansible-dokku

Ansible modules for installing and configuring Dokku
MIT License
156 stars 44 forks source link

Fix dokku_acl_app and dokku_acl_service ansible libraries #155

Closed ltalirz closed 1 year ago

ltalirz commented 1 year ago

This PR provides a couple of minor fixes:

  1. the dokku commands that list ACL information return the data on stderr, however the plugin was trying to read it from stdout. Added a redirect_stderr option on subprocess_check_output (which defaults to False, to avoid breaking usage anywhere else), and then modified dokku_acl_app and dokku_acl_service to set that to True
  2. The dokku_acl_service module wasn't using the right dokku acl:... commands to list/add/remove

This change is pretty small, I've tested this locally to confirm it works. Let me know if anything else is needed!