dokku / ansible-dokku

Ansible modules for installing and configuring Dokku
MIT License
156 stars 44 forks source link

Latest release missing from ansible-galaxy #159

Closed dvessey-fes closed 4 months ago

dvessey-fes commented 1 year ago

If you're using Dokku - especially for commercial purposes - consider donating to project development via OpenCollective or Patreon. Funds go to general development, support, and infrastructure costs.

If you'd like to sponsor specific functionality, see the project's Sponsoring document.

If you need support for a version of Dokku that is more than a year old, your issue may be closed without an answer. Please upgrade to a recent version before filing an issue.

Description of problem

Latest version for ansible-dokku on ansible-galaxy is v2022.10.17 https://galaxy.ansible.com/dokku_bot/ansible_dokku - but latest release https://github.com/dokku/ansible-dokku/releases v2022.12.19

Not sure if this is intended or a token expired somewhere?

Thanks!

ltalirz commented 1 year ago

thanks for the alert @dvessey-fes - indeed, I believe this here is the issue https://github.com/dokku/ansible-dokku/blob/b376657b41e40b6e6a185908352d5e40fdf71812/.github/workflows/ci.yml#L99

CI has been broken since some changes on the github actions side https://github.com/dokku/ansible-dokku/issues/154

I currently don't have time to investigate it unfortunately - if someone could have a look into this, that would be great

If not, we can make a short workaround and remove molecule from the needs for publishing the role (feel free to open a PR)

ltalirz commented 8 months ago

Thanks to @niicck for fixing the CI pipeline; just pushed another tag - let's see whether it works now https://github.com/dokku/ansible-dokku/actions/runs/6771491839

ltalirz commented 8 months ago

Unfortunately, now the github action that deploys uploads the role to ansible galaxy is broken because the new ansible galaxy release is broken https://github.com/robertdebock/galaxy-action/issues/12

A fix has been merged but not released

josegonzalez commented 6 months ago

The fix has been released :)

nerg4l commented 5 months ago

On ansible-galaxy the latest release of the library is still v2022.10.17. Is it simply a matter of pressing a button or is there something else that need to be fixed before releasing v2022.12.19?

ltalirz commented 5 months ago

Just re-pushed v2023.11.6 https://github.com/dokku/ansible-dokku/actions/runs/7958081917 - let's see whether it runs through

ltalirz commented 5 months ago

Unfortunately still getting

+ ansible-galaxy role import --api-key *** --branch master dokku ansible-dokku
ERROR! Error when finding available api versions from default (https://galaxy.ansible.com/) (HTTP Code: 403, Message: Forbidden)

If someone knows a working github action to publish galaxy roles, please open a PR

ltalirz commented 5 months ago

P.S. The action we're currently using is using a docker image; it's possible that the ansible galaxy version in there is outdated

josegonzalez commented 5 months ago

That image is this: https://github.com/robertdebock/docker-github-action-galaxy

Not sure what package in there needs to be updated, but maybe we can pull that image and validate that?

nerg4l commented 5 months ago

GitHub action link: https://github.com/robertdebock/galaxy-action DockerHub link to the image: https://hub.docker.com/r/robertdebock/github-action-galaxy/tags

ansible-galaxy [core 2.16.2]
  config file = None
  configured module search path = ['/root/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/local/lib/python3.12/site-packages/ansible
  ansible collection location = /root/.ansible/collections:/usr/share/ansible/collections
  executable location = /usr/local/bin/ansible-galaxy
  python version = 3.12.1 (main, Dec  9 2023, 00:54:56) [GCC 13.2.1 20231014] (/usr/local/bin/python3)
  jinja version = 3.1.3
  libyaml = True

But the Docker image is irrelevant because the previously linked issue was on the server side.

There was some activity on ansible/galaxy#1980. Could this solve the error https://github.com/ansible/galaxy/issues/1980#issuecomment-1789702529 ?

ltalirz commented 4 months ago

There was some activity on ansible/galaxy#1980. Could this solve the error ansible/galaxy#1980 (comment) ?

That's probably worth a try.

@josegonzalez Can you please create a new token at https://galaxy.ansible.com/ui/token/ and then try to ansible-galaxy role import dokku ansible-dokku --token <token>?

I tried it as well but I'm still getting a 403 (unfortunately they completely removed the UI on galaxy.ansible.com for looking at one's own collections, i.e. I don't see whether I have access to the ansible-dokku role on ansible galaxy or not).

If that works, please update the GALAXY_API_KEY on https://github.com/dokku/ansible-dokku/settings/secrets/actions

josegonzalez commented 4 months ago

I updated the token just now from the dokku-bot github user. Whats next?

ltalirz commented 4 months ago

Great, that did the trick!

I just re-ran the workflow https://github.com/dokku/ansible-dokku/actions/runs/7958081917 that previously failed - completes now.

New release is online https://galaxy.ansible.com/ui/standalone/roles/dokku_bot/ansible_dokku/versions/