dokku / ansible-dokku

Ansible modules for installing and configuring Dokku
MIT License
172 stars 44 forks source link

Fix CI verify stage #166

Closed Niicck closed 11 months ago

Niicck commented 11 months ago

All the molecule tests now pass locally for me. Let's see how it works in CI.

I cleaned up all the lingering bugs with our molecule tests, plus some new bugs that only showed up in the last couple of months.

Resolves: https://github.com/dokku/ansible-dokku/issues/154

Here's what I did:

Niicck commented 11 months ago

I think you can configure the repo to allow non-maintainers to run workflows: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/enabling-features-for-your-repository/managing-github-actions-settings-for-a-repository#allowing-select-actions-and-reusable-workflows-to-run

But I don't think it'll be a blocker. I figured out how to run molecule locally with different distros. So I should be able to identify the rest of the issues without needing to run them in the actual CI pipeline

Niicck commented 11 months ago

Alright, let's give it another run. I think all the distros should be working.

ltalirz commented 11 months ago

I think you can configure the repo to allow non-maintainers to run workflows: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/enabling-features-for-your-repository/managing-github-actions-settings-for-a-repository#allowing-select-actions-and-reusable-workflows-to-run

I believe this is about CI running on the upstream repository in the pull request. You should be able to run the workflows on your fork independently of any settings on the upstream repo.

In any case, the setting is currently

image

i.e. next time you will no longer be affected.

Thanks a lot for the contribution, much appreciated!