search

dokku / ansible-dokku

Ansible modules for installing and configuring Dokku
MIT License
169 stars 44 forks source link

Fix vhost file value #63

Closed atnartur closed 4 years ago

atnartur commented 4 years ago

Dokku takes base host for applications from VHOST file. This file contains hostname of operation system by default (ubuntu in my case). I fixed the value of VHOST with dokku_hostname variable.

May be related to #19

P. S. Tested with Ubuntu 18.04

josegonzalez commented 4 years ago

@ltalirz does this seem good to merge?

atnartur commented 4 years ago

Debian install scripts should set initial values to config files and shouldn't update this files in next times I think. Config files can be edited by users later.

In Ansible we want to update settings by changing a playbook. So values from playbook should always update files on the machine.

atnartur commented 4 years ago

Can we merge it?

ltalirz commented 4 years ago

I wanted to let @josegonzalez do the merge. If it isn't merged by end of the week, I'll merge it myself.

josegonzalez commented 4 years ago

Seems mergeable. If someone wants to file an issue for upstream as well, that would be good.