search

dokku / ansible-dokku

Ansible modules for installing and configuring Dokku
MIT License
176 stars 44 forks source link

add test for dokku_global_cert #74

Closed ltalirz closed 4 years ago

ltalirz commented 4 years ago

So far, CI is only testing that the role can be installed (with default options).

That's fine, but the role includes a number of features that aren't tested by this approach. Here, I'm adding a test for #72 as the 'verify' stage (which currently fails, and should be resolved after #73 is merged).

This approach can be used going forward to test any other feature that isn't part of the regular role setup.

ltalirz commented 4 years ago

@josegonzalez If you add a branch protection rule for master that PRs need to be "up to date", then you'll get a button here to "update" the PR (which should make the tests pass).

ltalirz commented 4 years ago

I see you trust my word more than I do ;-)