search

dokku / ansible-dokku

Ansible modules for installing and configuring Dokku
MIT License
176 stars 44 forks source link

move to github actions #86

Closed ltalirz closed 4 years ago

ltalirz commented 4 years ago

Travis CI starts to be more and more fragile. Github actions is faster and well integrated with GitHub repositories.

Furthermore, this commit moves the linting state to pre-commit hooks (=> faster turnaround) and autoformats yaml files (=> never fail builds because of yaml formatting again :-) ).

ltalirz commented 4 years ago

For GH actions build, see https://github.com/ltalirz/ansible-dokku/actions (I think these will start only on this repo once the PR is merged - otherwise one could do nasty things like extracting repo secrets etc.)

josegonzalez commented 4 years ago

@ltalirz let me know when this is ready for merge so I can disable travis and such :)

ltalirz commented 4 years ago

Just removed the comment from ci.yml - from my point of view this is ready to merge. As one can see here, tests pass: https://github.com/ltalirz/ansible-dokku/actions

Feel free to go ahead, and please add the ansible galaxy API key as a GALAXY_API_KEY secret of the repo (I can't). You find it at https://galaxy.ansible.com/me/preferences

ltalirz commented 4 years ago

I'm going to sleep; will check back tomorrow and merge a few more PRs

josegonzalez commented 4 years ago

Merged and disabled travis as best I could.

ltalirz commented 4 years ago

Feel free to go ahead, and please add the ansible galaxy API key as a GALAXY_API_KEY secret of the repo (I can't). You find it at https://galaxy.ansible.com/me/preferences

@josegonzalez Did you add this? I don't have the rights to check the secrets of the repo (and I don't have access to the ansible galaxy org; feel free to add me, my name there is also ltalirz).

The publish workflow failed: https://github.com/dokku/ansible-dokku/runs/1320330749?check_suite_focus=true , it just says 403 forbidden

josegonzalez commented 4 years ago

Ah right, i added the key for my github account, but it is the dokku_bot user that has access...

josegonzalez commented 4 years ago

Fixed to use the correct value.