dokku / ansible-dokku

Ansible modules for installing and configuring Dokku
MIT License
169 stars 44 forks source link

fix permissions for apt version pinning files #95

Closed ltalirz closed 3 years ago

ltalirz commented 3 years ago

Permissions of the pin files were left unspecified, resulting in 0600 in my test case, which is not recommended (and caused e.g. the check_apt binary of icinga to fail when not run as root).

ltalirz commented 3 years ago

@josegonzalez By the way, I still can't merge without a review (and I don't have permissions to change the settings to exclude administrators).

That's fine with me - just to explain why you'll get a couple of review requests ;-)

josegonzalez commented 3 years ago

@ltalirz added you as a maintainer

ltalirz commented 3 years ago

Thanks, but I still see this when I click on "settings":

image

ltalirz commented 3 years ago

I.e. I cannot change the branch protection rules and without your review I cannot merge this

image

josegonzalez commented 3 years ago

Try now?

ltalirz commented 3 years ago

Thanks, now it works!