search

dokku / ansible-dokku

Ansible modules for installing and configuring Dokku
MIT License
169 stars 44 forks source link

feat: make version pinning optional #97

Closed ltalirz closed 3 years ago

ltalirz commented 3 years ago

fixes #93

The ansible role was pinning the versions of dokku-related apt packages. In order to use the role with newer (or older) dokku versions, users of the role would have to figure out by themselves which versions of these packages were compatible - despite the fact that a simple apt-get install dokku would have taken care of the dependencies correctly.

Here we remove version pinning by default, while still giving users the option to pin the version of certain packages if they have a need to do so.

ltalirz commented 3 years ago

@josegonzalez If you have the time to have a quick look and give some input, also on the naming of the default values, please do! Otherwise I'll merge this some time later this week.

ltalirz commented 3 years ago

@josegonzalez To me this now looks good to merge.

The default None generated in the readme is perhaps not so pretty (it's the python representation..) but since they are deprecated I wouldn't worry.

Tests passed already in the previous commit; just fixing an ansible deprecation warning.