search

dokku / docker-container-healthchecker

Runs healthchecks against local docker containers
BSD 3-Clause "New" or "Revised" License
16 stars 4 forks source link

feat: add new on_failure parameter for healthchecks #27

Closed noeleont closed 1 year ago

noeleont commented 1 year ago

as mentioned in #11 the on_failure parameter contains:

command:

Runs a command on the host with data about the healthcheck and the failing container.

url:

Sends the failed check data to the specified url

noeleont commented 1 year ago

I'll move the changes to a onFailure function in appjson/healthcheck.go and reopen the PR.

noeleont commented 1 year ago

Since I'm not working with Go a lot can you tell me if this is a good approach or should I do it differently?

josegonzalez commented 1 year ago

Apologies for the late review, but this should be ready to try now :)

josegonzalez commented 1 year ago

Apologies for the late reply, but the code looks pretty good so far. Just needs a few fixes. Let me know if you'd like me to pick this up.

noeleont commented 1 year ago

No worries, I will pick it up in the next days, thanks for the review!

noeleont commented 1 year ago

@josegonzalez I implemented the changes :)

josegonzalez commented 1 year ago

Last two review comments, should be relatively easy to fix :)

noeleont commented 1 year ago

I rebased to your branch and squashed the commits to streamline the history. Thanks for your help!