search

dokku / dokku-daemon

A daemon wrapper around dokku
MIT License
32 stars 13 forks source link

Consider making Makefile Debian-aware #27

Open ltalirz opened 4 years ago

ltalirz commented 4 years ago

The Makefile currently only works on Debian, if one follows the instructions in the README and runs apt-get install socat first.

Otherwise, in trying to install socat, the Makefile will try to add the universe repository here: https://github.com/dokku/dokku-daemon/blob/c36a2460f9f7737bb4fb6621f6961773933a1409/Makefile#L38 which is specific to Ubuntu and does not exist for Debian (Debian has main, contrib and non-free).

As suggested by @josegonzalez , the Makefile could check

OS=$(shell lsb_release -si)

And then do a conditional if that is Ubuntu or Debian.

josegonzalez commented 3 years ago

Just seeing this!

As always, Pull requests welcome :)