search

dokku / dokku-elasticsearch

an elasticsearch plugin for dokku
MIT License
94 stars 35 forks source link

Installing a custom elasticsearch image --> replace "docker pull "$PLUGIN_IMAGE:$PLUGIN_IMAGE_VERSION"? #50

Closed dmr closed 7 years ago

dmr commented 7 years ago

I'm trying to build my own elasticsearch image which requires a specific version and plugins and the plugin always executes

docker pull "$PLUGIN_IMAGE:$PLUGIN_IMAGE_VERSION"

I think it would be more generic to only have one variable ELASTICSEARCH_IMAGE="elasticsearch:2.3.3 which would allow me to replace this with a custom url that I like.

Maybe I understood docker pull wrong but is there a reason for the second variable?

josegonzalez commented 7 years ago

We pull an image and a version of that image. You can do ELASTICSEARCH_IMAGE=dmr/yolo and ELASTICSEARCH_IMAGE_VERSION=latest if you wanted. They are separate because they are separate, nothing more.

dmr commented 7 years ago

I was hoping that I could use a git repository as a source because I use private repositories. I try to use a url as a image but that does not work yet

(http://stackoverflow.com/questions/26753030/how-to-build-docker-image-from-github-repository)

josegonzalez commented 7 years ago

This issue was moved to dokku/dokku-redis#83

khakulov commented 6 years ago 
export ELASTICSEARCH_IMAGE="docker.elastic.co/elasticsearch/elasticsearch"
export ELASTICSEARCH_IMAGE_VERSION="6.0.1"
dokku elasticsearch:create myinstance