search

dokku / dokku-maintenance

dokku plugin that gives the ability to manage application maintenance mode
MIT License
111 stars 13 forks source link

Maintenance Except a Few IP Addresses? #5

Closed aadrian closed 2 years ago

aadrian commented 7 years ago

Hi,

Would it be possible to have the "maintenance" mode work for everybody except a few IP addresses?

E.g. for an admin from one (of the few) IP addresses to be able to check the application after it's deployed and running, but still everybody else to see the maintenance.html ?

Thank you.

josegonzalez commented 7 years ago

Thats not possible with this plugin.

rNoz commented 4 years ago

Do you plan to support it?

At least can be "easy", like maintentance on --allow 78.78.56.56 (single IP) to allow, and then if ($remote_addr != 78.78.56.56) ... show the maintenance page.

josegonzalez commented 4 years ago

I do not plan to support it.

If someone would like to add the functionality with tests, I would consider merging it.

If someone would like to sponsor the work, I've published a document on doing so here.

josegonzalez commented 2 years ago

I'm going to close this. The plugin does what it says on the tin, and anything more would be a bit difficult/out of scope.

If anyone would like to sponsor the work, feel free to checkout this doc. As always, pull requests welcome!