search

dokku / dokku-mariadb

a mariadb plugin for dokku
MIT License
73 stars 26 forks source link

Adds parameters to backup-auth for region support and non AWS endpoint support #61

Closed luflow closed 7 years ago

luflow commented 7 years ago

Hi everyone!

We recently started using minio as S3-compatbile microservice and want to use it now for our mariadb backups.

To get there this is the second pull request of two. The first one was already published and is a prerequisite for this pr: https://github.com/dokku/s3gof3r-docker/pull/1

With this pr we can now use three new optional parameters for the backup-auth command:

  1. AWS Region (new parameter in third place)
  2. AWS Signature Version (new parameter in fourth place)
  3. Different endpoints instead of only the default AWS S3 endpoint (new parameter in fifth place)

Special thanks to mbegenau for helping me out while coding these additions.

luflow commented 7 years ago

@josegonzalez the lint tool is happy now, too ;)

luflow commented 7 years ago

@josegonzalez I also updated the code now to use the newest version (0.7) of dokkupaas/s3backup - thank you for accepting the first merge request :)

luflow commented 7 years ago

@josegonzalez is there anything more to do to get this into the next plugin version? Would love to use this in production!

I will also apply this patch set to all other plugins with AWS backup functionality if you like :)

josegonzalez commented 7 years ago

Yeah I basically have to go through and apply this + some other changes everywhere. Should be soon - I will have some time this weekend.

luflow commented 7 years ago

@josegonzalez Awesome! If there is anything I can help you to accelerate the publishing of the new version.