search

dokku / dokku-mongo

a mongo plugin for dokku
MIT License
177 stars 32 forks source link

IAM auth doesn't work for backups #96

Closed jlcastillo closed 6 years ago

jlcastillo commented 6 years ago

Problems:

1) the code in common-functions => service_backup() is clearly wrong, it always throws an error message when you set the --use-iam option. It was apparently copy-pasted from the dokku postgres plugin.

2) the mongo:backup-auth should allow to store the --use-iam preferences, otherwise those cannot be passed to mongo:backup-schedule.

3) mongo:backup-schedule should write the --use-iam in CRON, so that mongo:backup can receive it.

josegonzalez commented 6 years ago

Good catch. I'll see if I can somehow repro the bugs locally and fix - testing IAM backups is a pain as there isn't a super bulletproof way of doing it other than spinning up an AWS instance, which can be a bit costly.

josegonzalez commented 6 years ago

Closing in favor of the linked redis issue. I'm hoping I'll have some time this week to devote to fixing this issue - should be straightforward to fix at least the :backup subcommand - but would appreciate any help in all cases :)