dokku / dokku-redirect

A plugin for dokku that gives the ability to set simple redirects for an application
MIT License
106 stars 9 forks source link

Target host is missing in "Configuring redirect" log message #24

Closed IlyaSemenov closed 6 years ago

IlyaSemenov commented 6 years ago

With redirect from www.test.com to test.com, this malformed log message is printed:

Configuring redirect for www.test.com to  via HTTP 301...

Steps to reproduce

On the host:

# dokku apps:create test
-----> Creating test... done
# dokku redirect:set test www.test.com test.com
-----> Setting redirect for test...
       Done

On the devops machine:

 ~  cd tmp
 ~/tmp  mkdir test
 ~/tmp  cd test
 ~/tmp/test  touch .static
 ~/tmp/test  echo test > index.html
 ~/tmp/test  git init .
Initialized empty Git repository in /Users/semenov/tmp/test/.git/
 ~/tmp/test  ⎇ master …  git add .
 ~/tmp/test  ⎇ master ~  git ci -m "test"
[master (root-commit) d1893f9] test
 2 files changed, 1 insertion(+)
 create mode 100644 .static
 create mode 100644 index.html
 ~/tmp/test  ⎇ master  git push dokku@dokku.host:test master
Counting objects: 4, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (2/2), done.
Writing objects: 100% (4/4), 257 bytes | 257.00 KiB/s, done.
Total 4 (delta 0), reused 0 (delta 0)
remote: Preparing /tmp/dokku_git.b03a (identifier dokku_git.b03a)
remote: ~/test /tmp/dokku_git.b03a ~/test
remote: /tmp/dokku_git.b03a ~/test
-----> Cleaning up...
-----> Building test from herokuish...
....
....
-----> Configuring test.localhost...(using built-in template)
-----> Creating http nginx.conf
-----> Running nginx-pre-reload
-----> Configuring redirect for www.test.com to  via HTTP 301...
       Reloading nginx

The redirect works, the problem is only in the output.

Expected result

-----> Configuring redirect for www.test.com to test.com via HTTP 301...

Environment

Ubuntu 18.04 Dokku version 0.12.9 Dokku-redirect 607615c2139dcde4413862f1ad22a4a440b77775 ("Release 0.6.1")

# cat /home/dokku/test/REDIRECTS
www.test.com:test.com:301
# grep 301 /home/dokku/test/nginx.conf
  return 301  $scheme://test.com$request_uri;