search

dokku / dokku-redirect

A plugin for dokku that gives the ability to set simple redirects for an application
MIT License
107 stars 9 forks source link

Removal of SPDY in 0.30.0 causes warning/error when deploying with this plugin #35

Closed cooperaj closed 1 year ago

cooperaj commented 1 year ago

If you're using Dokku - especially for commercial purposes - consider donating to project development via OpenCollective or Patreon. Funds go to general development, support, and infrastructure costs.

If you'd like to sponsor specific functionality, see the project's Sponsoring document.

If you need support for a version of Dokku that is more than a year old, your issue may be closed without an answer. Please upgrade to a recent version before filing an issue.

Description of problem

When using Dokku 0.30.0 and this plugin a deploy of your application will result in remote: /var/lib/dokku/plugins/enabled/redirect/nginx-pre-reload: line 36: is_spdy_enabled: command not found being show as a part of the deployment output. It all appears to work fine though so it may just be a warning but it is concerning.

How reproducible

Use this plugin and Dokku 0.30.0+. Deploy a project using redirects.

Steps to Reproduce

  1. Have redirects
  2. Deploy project

Actual Results

Error remote: /var/lib/dokku/plugins/enabled/redirect/nginx-pre-reload: line 36: is_spdy_enabled: command not found shown in logs but it all appears to still work.

Expected Results

No errors.

I don't believe any further information is necessary/pertinent but if it's needed I can provide. I believe this issue can be solved by removing a single line from the nginx-pre-reload file but I imagine this will have to wait until the SPDY deprecation completes?

josegonzalez commented 1 year ago

Thanks for reporting!

cooperaj commented 1 year ago

Just looking at the fix I don't think it touched the nginx-pre-reload plugin file? Maybe I'm mistaken but that code will still run as it's the code that ended up defining the variable that was used in the template the fix touched.

Unless the variable isn't resolved until access time?

josegonzalez commented 1 year ago

Fixed that here: https://github.com/dokku/dokku-redirect/commit/3afa4c20062143497ab7d4e2bbd3dad278177230