search

dokku / dokku-redirect

A plugin for dokku that gives the ability to set simple redirects for an application
MIT License
106 stars 9 forks source link

HTTPS redirection not created #4

Closed marvinroger closed 8 years ago

marvinroger commented 8 years ago

I've just upgraded from the latest 0.4.x to 0.5.4 and rebuilt all apps. Only the http redirection in created, not the https one. (the is_ssl_enabled is not even evaluated true, even if server.crt and server.key exist).

marvinroger commented 8 years ago

On v4.x, the is_ssl_enabled prints app or global, which you check. But on the v5, the function only return 1 or 0. So L29, L34 and L41 needs to be updated to reflect the changes. ;)

marvinroger commented 8 years ago

Since this is an official plugin and @Flink is inactive, any chance @josegonzalez can fix this? It should be really easy and quick to fix.

josegonzalez commented 8 years ago

@marvinroger I don't use the plugin - and am a bit swamped with work at the moment - but I would definitely be open to a pr from an interested party ;)

michaelshobbs commented 8 years ago

While this might be an easy fix, this plugin will need to be updated further to work with dokku 0.5.x. See #3 for reference

houli commented 8 years ago

Have run into this myself. Is there any further progress on fixing the migration to dokku 0.5? It would be nice if "official" plugins were part of core and were part of the testing process for new releases of dokku.

marvinroger commented 8 years ago

The PR I've opened fixes the issue. :)