dokku / dokku-redis

a redis plugin for dokku
MIT License
256 stars 38 forks source link

Unable to link Postgres with precise environment variable name #196

Open cosmin opened 1 year ago

cosmin commented 1 year ago

Description of problem

Unable to link Postgres with custom environment variable name, _URL gets appended to the end of the name specified with -a.

I can work around this by modifying the app, but it would be much better if I didn't have to modify the app and instead I could have Dokku link with a precise environment variable name.

How reproducible

Steps to Reproduce

  1. dokku postgres:link myappdb myapp -a DATABASE_SERVER
  2. dokku config:show myapp

Actual Results

DATABASE_SERVER_URL:  postgres://postgres:xxxxxxxxxx@dokku-postgres-myappdb:5432/myappdb

Expected Results

DATABASE_SERVER:  postgres://postgres:xxxxxxxxxx@dokku-postgres-myappdb:5432/myappdb
josegonzalez commented 1 year ago

Yeah this is by design at the moment. The _URL always gets appended.

cosmin commented 1 year ago

@josegonzalez why did this get moved to dokku-redis since it's about the postgres plugin. Was this an accident?

josegonzalez commented 1 year ago

No this was purposeful. I use this issue tracker to track all datastore-wide enhancement requests and bug fixes.