dokku / github-action

MIT License
168 stars 30 forks source link

Missing v1 tag #12

Closed lovasoa closed 2 months ago

lovasoa commented 3 years ago

Hello, The dokku docs mention the following github workflow file:

---
name: 'deploy'

on:
  push:
    branches:
      - master

jobs:
  deploy:
    runs-on: ubuntu-latest
    steps:
      - name: Cloning repo
        uses: actions/checkout@v2
        with:
          fetch-depth: 0

      - name: Push to dokku
        uses: dokku/github-action@v1 # <-- problem
        with:
          git_remote_url: 'ssh://dokku@dokku.me:22/appname'
          ssh_private_key: ${{ secrets.SSH_PRIVATE_KEY }}

source: https://dokku.com/docs/deployment/continuous-integration/github-actions/

However, this does not work, because there is no v1 tag in this repo. It would be great to create a v1 tag and point it (currently) to v1.0.2.

pawelad commented 1 year ago

This would be great - ideally, v1 should point to the latest v1.X.Y release (currently it's v1.4.0), which I think is the de-facto standard with GitHub Actions (i.e. https://github.com/actions/checkout/tags).

josegonzalez commented 1 year ago

Does anyone know how other actions do that automatically?

pawelad commented 1 year ago

GitHub docs don't mention any 'official way' and the two GitHub-owned actions I checked (the ones I use the most often) use two (slightly) different approaches...

https://github.com/actions/checkout/blob/main/.github/workflows/update-main-version.yml

https://github.com/actions/setup-python/blob/main/.github/workflows/release-new-action-version.yml

josegonzalez commented 2 months ago

I'm creating the v1 tag now manually.