search

dokku / github-action

MIT License
168 stars 30 forks source link

Add example workflow for deploying remote docker image #5

Closed badsyntax closed 2 years ago

badsyntax commented 3 years ago

Related to https://github.com/dokku/dokku/issues/4296

I totally get that this is a hack/workaround, but IMO it can be a useful reference for others.

If/once https://github.com/dokku/dokku/issues/4296 is shipped we can update this example to use the new git:from-image feature.

jsmestad commented 2 years ago

I was testing this out today and ran into an issue with the push succeeding but reporting a failure due to shallow clone. Any ideas?

! [remote rejected] 3b793800bd3d7eef55100691d23fb7e04ae8f840 -> master (shallow update not allowed)

Does this have to do with the git init ... stuff somehow?

josegonzalez commented 2 years ago

The git:from-image was shipped so this should switch to that.

jsmestad commented 2 years ago

Oh I was not sure how to do that from Github Actions so I thought this was doing that. Looking at the docs the commands are dokku git:from-image, I didn't see anything that shows how to then push a new release using that? I couldn't wrap my head around how git push dokku@my.dokku.me:myapp.git would work with that command

josegonzalez commented 2 years ago

This is now implemented via git:from-image documented here as of #21. Thanks to everyone that put up ideas on how this could be implemented :)