Dokku push action does not update app variable.

Alin-Dumitrescu commented 2 months ago

Description of problem

I have set an application variable APP_VERSION for the app web on the dokku server. When using the git-action, the process is NOT updating the APP_VERSION variable as expected. There is an unexpected "Invalid IP address" message in the logs.

How reproducible

Every time.

Steps to Reproduce

set APP_VERSION variable, GIT_SSH_COMMAND add git-hub action:
```
GIT_SSH_COMMAND: 'ssh -o SendEnv=APP_VERSION'
```

name: Push to Dokku uses: dokku/github-action@v1.6.0 with: git_remote_url: 'ssh://dokku@uat.trainerday.com:22/web' ssh_private_key: ${{ secrets.DEPLOY_SSH_PRIVATE_KEY }} branch: "${{ env.BRANCH_NAME }}" git_push_flags: '--force' trace: 1
```
2. execute workflow
#### Actual Results
```

APP_VERSION is not updated (keeps the old value of 4.0.2) - see line 1433 in the attached log.

Expected Results

APP_VERSION is updated to 4.0.2-30

Environment Information

`dokku report APP_NAME` output

dokku report web
-----> uname: Linux dokku2024-stage 5.15.0-122-generic #132-Ubuntu SMP Thu Aug 29 13:45:52 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
-----> memory:
                      total        used        free      shared  buff/cache   available
       Mem:            3911        1896         540           5        1475        1718
       Swap:              0           0           0
-----> disk utilization:
       Filesystem      Size  Used Avail Use% Mounted on
       /dev/vda1        78G   62G   16G  81% /
       /dev/vda15      105M  6.1M   99M   6% /boot/efi
-----> disk inode utilization:
       Filesystem     Inodes IUsed IFree IUse% Mounted on
       /dev/vda1        9.9M  2.5M  7.5M   25% /
       /dev/vda15          0     0     0     - /boot/efi
-----> docker version:
       Client: Docker Engine - Community
        Version:           26.1.4
        API version:       1.45
        Go version:        go1.21.11
        Git commit:        5650f9b
        Built:             Wed Jun  5 11:28:57 2024
        OS/Arch:           linux/amd64
        Context:           default

       Server: Docker Engine - Community
        Engine:
         Version:          26.1.4
         API version:      1.45 (minimum version 1.24)
         Go version:       go1.21.11
         Git commit:       de5c9cf
         Built:            Wed Jun  5 11:28:57 2024
         OS/Arch:          linux/amd64
         Experimental:     false
        containerd:
         Version:          1.6.33
         GitCommit:        d2d58213f83a351ca8f528a95fbd145f5654e957
        runc:
         Version:          1.1.12
         GitCommit:        v1.1.12-0-g51d5e94
        docker-init:
         Version:          0.19.0
         GitCommit:        de40ad0
-----> docker daemon info:
       Client: Docker Engine - Community
        Version:    26.1.4
        Context:    default
        Debug Mode: true
        Plugins:
         buildx: Docker Buildx (Docker Inc.)
           Version:  v0.14.1
           Path:     /usr/libexec/docker/cli-plugins/docker-buildx
         compose: Docker Compose (Docker Inc.)
           Version:  v2.27.1
           Path:     /usr/libexec/docker/cli-plugins/docker-compose

       Server:
        Containers: 18
         Running: 16
         Paused: 0
         Stopped: 2
        Images: 40
        Server Version: 26.1.4
        Storage Driver: overlay2
         Backing Filesystem: extfs
         Supports d_type: true
         Using metacopy: false
         Native Overlay Diff: true
         userxattr: false
        Logging Driver: json-file
        Cgroup Driver: systemd
        Cgroup Version: 2
        Plugins:
         Volume: local
         Network: bridge host ipvlan macvlan null overlay
         Log: awslogs fluentd gcplogs gelf journald json-file local splunk syslog
        Swarm: inactive
        Runtimes: io.containerd.runc.v2 runc
        Default Runtime: runc
        Init Binary: docker-init
        containerd version: d2d58213f83a351ca8f528a95fbd145f5654e957
        runc version: v1.1.12-0-g51d5e94
        init version: de40ad0
        Security Options:
         apparmor
         seccomp
          Profile: builtin
         cgroupns
        Kernel Version: 5.15.0-122-generic
        Operating System: Ubuntu 22.04.4 LTS
        OSType: linux
        Architecture: x86_64
        CPUs: 2
        Total Memory: 3.82GiB
        Name: dokku2024-stage
        ID: 96fddca3-0ed0-4664-b453-70d5b5033ded
        Docker Root Dir: /var/lib/docker
        Debug Mode: false
         File Descriptors: 122
         Goroutines: 109
         System Time: 2024-09-23T11:03:08.476257651Z
         EventsListeners: 1
        Experimental: false
        Insecure Registries:
         127.0.0.0/8
        Live Restore Enabled: false

-----> herokuish version:
 !     Herokuish image gliderlabs/herokuish:latest-22 is not available
-----> dokku version: dokku version 0.34.5
-----> dokku-event-listener version: v0.16.2
-----> dokku-update version: dokku-update v0.9.3
-----> docker-container-healthchecker version: v0.10.4
-----> docker-image-labeler version: v0.7.1
-----> git version: git version 2.34.1
-----> lambda-builder version:        v0.7.2                                    
-----> netrc version: v0.9.1
 !     pack binary is not available
-----> plugn version: plugn: v0.15.3
-----> sigil version: 0.10.1build+e443be0
-----> sshcommand version: sshcommand v0.18.0
-----> dokku plugins:
         00_dokku-standard    0.34.5 enabled    dokku core standard plugin
         20_events            0.34.5 enabled    dokku core events logging plugin
         app-json             0.34.5 enabled    dokku core app-json plugin
         apps                 0.34.5 enabled    dokku core apps plugin
         builder              0.34.5 enabled    dokku core builder plugin
         builder-dockerfile   0.34.5 enabled    dokku core builder-dockerfile plugin
         builder-herokuish    0.34.5 enabled    dokku core builder-herokuish plugin
         builder-lambda       0.34.5 enabled    dokku core builder-lambda plugin
         builder-nixpacks     0.34.5 enabled    dokku core builder-nixpacks plugin
         builder-null         0.34.5 enabled    dokku core builder-null plugin
         builder-pack         0.34.5 enabled    dokku core builder-pack plugin
         buildpacks           0.34.5 enabled    dokku core buildpacks plugin
         caddy-vhosts         0.34.5 enabled    dokku core caddy-vhosts plugin
         certs                0.34.5 enabled    dokku core certificate management plugin
         checks               0.34.5 enabled    dokku core checks plugin
         common               0.34.5 enabled    dokku core common plugin
         config               0.34.5 enabled    dokku core config plugin
         cron                 0.34.5 enabled    dokku core cron plugin
         docker-options       0.34.5 enabled    dokku core docker-options plugin
         domains              0.34.5 enabled    dokku core domains plugin
         enter                0.34.5 enabled    dokku core enter plugin
         git                  0.34.5 enabled    dokku core git plugin
         haproxy-vhosts       0.34.5 enabled    dokku core haproxy-vhosts plugin
         letsencrypt          0.20.3 enabled    Automated installation of let's encrypt TLS certificates
         logs                 0.34.5 enabled    dokku core logs plugin
         network              0.34.5 enabled    dokku core network plugin
         nginx-vhosts         0.34.5 enabled    dokku core nginx-vhosts plugin
         openresty-vhosts     0.34.5 enabled    dokku core openresty-vhosts plugin
         plugin               0.34.5 enabled    dokku core plugin plugin
         ports                0.34.5 enabled    dokku core ports plugin
         proxy                0.34.5 enabled    dokku core proxy plugin
         ps                   0.34.5 enabled    dokku core ps plugin
         redis                1.37.6 enabled    dokku redis service plugin
         registry             0.34.5 enabled    dokku core registry plugin
         repo                 0.34.5 enabled    dokku core repo plugin
         resource             0.34.5 enabled    dokku core resource plugin
         run                  0.34.5 enabled    dokku core run plugin
         scheduler            0.34.5 enabled    dokku core scheduler plugin
         scheduler-docker-local 0.34.5 enabled    dokku core scheduler-docker-local plugin
         scheduler-k3s        0.34.5 enabled    dokku core scheduler-k3s plugin
         scheduler-null       0.34.5 enabled    dokku core scheduler-null plugin
         shell                0.34.5 enabled    dokku core shell plugin
         ssh-keys             0.34.5 enabled    dokku core ssh-keys plugin
         storage              0.34.5 enabled    dokku core storage plugin
         trace                0.34.5 enabled    dokku core trace plugin
         traefik-vhosts       0.34.5 enabled    dokku core traefik-vhosts plugin
=====> web app-json information
       App json computed selected:    app.json
       App json global selected:      app.json
       App json selected:
=====> web app information
       App created at:                1712820657
       App deploy source:             git-push
       App deploy source metadata:    9eae1c25d04a109df98bbe09dff28b4364c76f96
       App dir:                       /home/dokku/web
       App locked:                    false
=====> web builder information
       Builder build dir:
       Builder computed build dir:
       Builder computed selected:
       Builder global build dir:
       Builder global selected:
       Builder selected:
=====> web builder-dockerfile information
       Builder dockerfile computed dockerfile path: Dockerfile
       Builder dockerfile global dockerfile path: Dockerfile
       Builder dockerfile dockerfile path:
=====> web builder-herokuish information
       Builder herokuish computed allowed: true
       Builder herokuish global allowed: true
       Builder herokuish allowed:
=====> web builder-lambda information
       Builder lambda computed lambdayml path: lambda.yml
       Builder lambda global lambdayml path: lambda.yml
       Builder lambda lambdayml path:
=====> web builder-nixpacks information
       Builder nixpacks computed nixpackstoml path: nixpacks.toml
       Builder nixpacks global nixpackstoml path: nixpacks.toml
       Builder nixpacks nixpackstoml path:
       Builder nixpacks computed no cache: false
       Builder nixpacks global no cache: false
       Builder nixpacks no cache:
=====> web builder-pack information
       Builder pack computed projecttoml path: project.toml
       Builder pack global projecttoml path: project.toml
       Builder pack projecttoml path:
=====> web buildpacks information
       Buildpacks computed stack:     gliderlabs/herokuish:latest-22
       Buildpacks global stack:
       Buildpacks list:
       Buildpacks stack:
=====> web caddy information
       Caddy image:                   lucaslorentz/caddy-docker-proxy:2.9
       Caddy letsencrypt email:
       Caddy letsencrypt server:      https://acme-v02.api.letsencrypt.org/directory
       Caddy log level:               ERROR
       Caddy polling interval:        5s
       Caddy tls internal:            false
=====> web ssl information
       Ssl dir:                       /home/dokku/web/tls
       Ssl enabled:                   true
       Ssl hostnames:                 app.uat.trainerday.com
       Ssl expires at:                Dec 17 04:52:49 2024 GMT
       Ssl issuer:                    C = US, O = Let's Encrypt, CN = E5
       Ssl starts at:                 Sep 18 04:52:50 2024 GMT
       Ssl subject:                   subject=CN = app.uat.trainerday.com
       Ssl verified:                  verified by a certificate authority
=====> web checks information
       Checks disabled list:          none
       Checks skipped list:           none
       Checks computed wait to retire: 60
       Checks global wait to retire:  60
       Checks wait to retire:
=====> web docker options information
       Docker options build:
       Docker options deploy:         --restart=on-failure:10
       Docker options run:
=====> web domains information
       Domains app enabled:           true
       Domains app vhosts:            app.uat.trainerday.com
       Domains global enabled:        true
       Domains global vhosts:         uat.trainerday.com
=====> web git information
       Git deploy branch:             master
       Git global deploy branch:      master
       Git keep git dir:              false
       Git rev env var:               GIT_REV
       Git sha:                       9eae1c25d04a109df98bbe09dff28b4364c76f96
       Git source image:
       Git last updated at:           1727087969
=====> web haproxy information
       Haproxy image:                 byjg/easy-haproxy:4.4.0
       Haproxy letsencrypt email:
       Haproxy letsencrypt server:    https://acme-v02.api.letsencrypt.org/directory
       Haproxy log level:             ERROR
=====> web letsencrypt information
       Letsencrypt active:            true
       Letsencrypt autorenew:         true
       Letsencrypt computed dns provider:
       Letsencrypt global dns provider:
       Letsencrypt dns provider:
       Letsencrypt computed email:    av@totxt.net
       Letsencrypt global email:      av@totxt.net
       Letsencrypt email:
       Letsencrypt expiration:        1734411169
       Letsencrypt computed graceperiod: 2592000
       Letsencrypt global graceperiod:
       Letsencrypt graceperiod:
       Letsencrypt computed lego docker args:
       Letsencrypt global lego docker args:
       Letsencrypt lego docker args:
       Letsencrypt computed server:   https://acme-v02.api.letsencrypt.org/directory
       Letsencrypt global server:
       Letsencrypt server:
=====> web logs information
       Logs computed max size:        10m
       Logs global max size:          10m
       Logs global vector sink:
       Logs max size:
       Logs vector global image:      timberio/vector:0.38.0-debian
       Logs vector sink:
=====> web network information
       Network attach post create:
       Network attach post deploy:
       Network bind all interfaces:          false
       Network computed attach post create:
       Network computed attach post deploy:
       Network computed bind all interfaces: false
       Network computed initial network:
       Network computed tld:
       Network global attach post create:
       Network global attach post deploy:
       Network global bind all interfaces:   false
       Network global initial network:
       Network global tld:
       Network initial network:
       Network static web listener:
       Network tld:
       Network web listeners:                172.17.0.16:5000
=====> web nginx information
       Nginx access log format:
       Nginx computed access log format:
       Nginx global access log format:
       Nginx access log path:
       Nginx computed access log path: /var/log/nginx/web-access.log
       Nginx global access log path:  /var/log/nginx/web-access.log
       Nginx bind address ipv4:
       Nginx computed bind address ipv4:
       Nginx global bind address ipv4:
       Nginx bind address ipv6:
       Nginx computed bind address ipv6: ::
       Nginx global bind address ipv6: ::
       Nginx client max body size:
       Nginx computed client max body size: 1m
       Nginx global client max body size: 1m
       Nginx disable custom config:
       Nginx computed disable custom config: false
       Nginx global disable custom config: false
       Nginx error log path:
       Nginx computed error log path: /var/log/nginx/web-error.log
       Nginx global error log path:   /var/log/nginx/web-error.log
       Nginx hsts include subdomains:
       Nginx computed hsts include subdomains: true
       Nginx global hsts include subdomains: true
       Nginx hsts max age:
       Nginx computed hsts max age:   15724800
       Nginx global hsts max age:     15724800
       Nginx hsts preload:
       Nginx computed hsts preload:   false
       Nginx global hsts preload:     false
       Nginx hsts:
       Nginx computed hsts:           true
       Nginx global hsts:             true
       Nginx last visited at:
       Nginx nginx conf sigil path:
       Nginx computed nginx conf sigil path: nginx.conf.sigil
       Nginx global nginx conf sigil path: nginx.conf.sigil
       Nginx proxy buffer size:
       Nginx computed proxy buffer size: 4k
       Nginx global proxy buffer size: 4k
       Nginx proxy buffering:
       Nginx computed proxy buffering: on
       Nginx global proxy buffering:  on
       Nginx proxy buffers:
       Nginx computed proxy buffers:  8 4k
       Nginx global proxy buffers:    8 4k
       Nginx proxy busy buffers size:
       Nginx computed proxy busy buffers size: 8k
       Nginx global proxy busy buffers size: 8k
       Nginx proxy read timeout:
       Nginx computed proxy read timeout: 60s
       Nginx global proxy read timeout: 60s
       Nginx underscore in headers:
       Nginx computed underscore in headers: off
       Nginx global underscore in headers: off
       Nginx x forwarded for value:
       Nginx computed x forwarded for value: $remote_addr
       Nginx global x forwarded for value: $remote_addr
       Nginx x forwarded port value:
       Nginx computed x forwarded port value: $server_port
       Nginx global x forwarded port value: $server_port
       Nginx x forwarded proto value:
       Nginx computed x forwarded proto value: $scheme
       Nginx global x forwarded proto value: $scheme
       Nginx x forwarded ssl:
       Nginx computed x forwarded ssl:
       Nginx global x forwarded ssl:
=====> web openresty information
       Openresty access log format:
       Openresty access log path:     /var/log/nginx/web-access.log
       Openresty allowed letsencrypt domains func base64: cmV0dXJuIHRydWUK      
       Openresty bind address ipv4:
       Openresty bind address ipv6:   ::
       Openresty client max body size:
       Openresty error log path:      /var/log/nginx/web-error.log
       Openresty global hsts:         true
       Openresty computed hsts:       true
       Openresty hsts:
       Openresty hsts include subdomains: true
       Openresty hsts max age:        15724800
       Openresty hsts preload:        false
       Openresty image:               dokku/openresty-docker-proxy:0.8.0
       Openresty letsencrypt email:
       Openresty letsencrypt server:  https://acme-v02.api.letsencrypt.org/directory
       Openresty proxy buffer size:   4k
       Openresty proxy buffering:     on
       Openresty proxy buffers:       8 4k
       Openresty proxy busy buffers size: 8k
       Openresty proxy read timeout:  60s
       Openresty underscore in headers: off
       Openresty x forwarded for value: $remote_addr
       Openresty x forwarded port value: $server_port
       Openresty x forwarded proto value: $scheme
       Openresty x forwarded ssl:
=====> web ports information
       Ports map:
       Ports map detected:            http:80:5000 https:443:5000
=====> web proxy information
       Proxy computed type:           nginx
       Proxy enabled:                 true
       Proxy global type:             nginx
       Proxy type:
=====> web ps information
       Deployed:                      true
       Processes:                     1
       Ps can scale:                  true
       Ps computed procfile path:     Procfile
       Ps global procfile path:       Procfile
       Ps procfile path:
       Ps restart policy:             on-failure:10
       Restore:                       true
       Running:                       true
       Status web 1:                  running (CID: e1994e4131c)
=====> web registry information
       Registry computed image repo:        dokku/web
       Registry computed push on release:   false
       Registry computed server:
       Registry global image repo template:
       Registry global push on release:
       Registry global server:
       Registry image repo:
       Registry push extra tags:
       Registry push on release:
       Registry server:
       Registry tag version:
=====> web resource information
=====> web scheduler information
       Scheduler computed selected:   docker-local
       Scheduler global selected:     docker-local
       Scheduler selected:
=====> web scheduler-docker-local information
       Scheduler docker local init process: true
       Scheduler docker local parallel schedule count:
=====> web scheduler-k3s information
       Scheduler k3s computed deploy timeout:       300s
       Scheduler k3s computed image pull secrets:
       Scheduler k3s computed letsencrypt server:   prod
       Scheduler k3s computed namespace:            default
       Scheduler k3s computed rollback on failure:  false
       Scheduler k3s deploy timeout:
       Scheduler k3s global deploy timeout:         300s
       Scheduler k3s global image pull secrets:
       Scheduler k3s global ingress class:          nginx
       Scheduler k3s global kube context:
       Scheduler k3s global kubeconfig path:        /etc/rancher/k3s/k3s.yaml
       Scheduler k3s global letsencrypt email prod:
       Scheduler k3s global letsencrypt email stag:
       Scheduler k3s global letsencrypt server:     prod
       Scheduler k3s global namespace:              default
       Scheduler k3s global network interface:      eth0
       Scheduler k3s global rollback on failure:    false
       Scheduler k3s image pull secrets:
       Scheduler k3s letsencrypt server:
       Scheduler k3s namespace:
       Scheduler k3s rollback on failure:
=====> web storage information
       Storage build mounts:
       Storage deploy mounts:
       Storage run mounts:
=====> web traefik information
       Traefik api enabled:           false
       Traefik api vhost:             traefik.dokku.me
       Traefik basic auth password:
       Traefik basic auth username:
       Traefik dashboard enabled:     false
       Traefik image:                 traefik:2.11.2
       Traefik letsencrypt email:
       Traefik letsencrypt server:    https://acme-v02.api.letsencrypt.org/directory
       Traefik log level:             ERROR
       Traefik http entry point:      http
       Traefik https entry point:     https

How (deb/make) and where (AWS, VirtualBox, physical, etc.) was Dokku installed?:

Digital Ocean dokku droplet

Additional information

dokku ps:inspect web

[
    {
        "AppArmorProfile": "docker-default",
        "Args": [
            "web"
        ],
        "Config": {
            "AttachStderr": true,
            "AttachStdin": false,
            "AttachStdout": true,
            "Cmd": [
                "/start",
                "web"
            ],
            "Domainname": "",
            "Entrypoint": null,
            "Env": [
                "USER=herokuishuser",
                "AWS_S3_ACCESS=XXXXXX",
                "CURL_TIMEOUT=XXXXXX",
                "DOKKU_APP_RESTORE=1",
                "GOOGLE_PLAY_SERVICE_ACC_KEY=XXXXXX",
                "MONGO_URI=XXXXXX",
                "AWS_QUEUE_SECRET_KEY=XXXXXX",
                "DOKKU_PROXY_PORT=80",
                "DOKKU_PROXY_SSL_PORT=443",
                "GOOGLE_PLAY_SERVICE_ACC_EMAIL=XXXXXX",
                "MONGO_ATLAS_PEM_FILE=XXXXXX",
                "APP_VERSION=XXXXXX",
                "AWS_S3_KEY=XXXXXX",
                "GIT_REV=XXXXXX",
                "OPENAI_API_KEY=XXXXXX",
                "DYNO=web.1",
                "PORT=5000",
                "APP_ENV=XXXXXX",
                "AWS_QUEUE_ACCESS_KEY=XXXXXX",
                "CURL_CONNECT_TIMEOUT=XXXXXX",
                "DOKKU_APP_TYPE=herokuish",
                "MONGO_CERT=XXXXXX",
                "CACHE_PATH=/cache",
                "PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin",
                "STACK=XXXXXX",
                "DEBIAN_FRONTEND=XXXXXX",
                "BASH_BIN=XXXXXX",
                "HEROKUISH_DISABLE_CHOWN=XXXXXX",
                "HEROKUISH_SETUIDGUID=XXXXXX"
            ],
            "Hostname": "e1994e4131cf",
            "Image": "dokku/web:latest",
            "Labels": {
                "com.dokku.app-name": "web",
                "com.dokku.builder-type": "herokuish",
                "com.dokku.container-type": "deploy",
                "com.dokku.dyno": "web.1",
                "com.dokku.image-stage": "release",
                "com.dokku.process-type": "web",
                "com.gliderlabs.herokuish/stack": "heroku-22",
                "dokku": "",
                "openresty.access-log-path": "/var/log/nginx/web-access.log",
                "openresty.bind-address-ipv6": "::",
                "openresty.domains": "app.uat.trainerday.com",
                "openresty.error-log-path": "/var/log/nginx/web-error.log",
                "openresty.hsts": "true",
                "openresty.hsts-include-subdomains": "true",
                "openresty.hsts-max-age": "15724800",
                "openresty.hsts-preload": "false",
                "openresty.https-port": "443",
                "openresty.letsencrypt": "false",
                "openresty.port-mapping": "http:80:5000 https:443:5000",
                "openresty.proxy-buffer-size": "4k",
                "openresty.proxy-buffering": "on",
                "openresty.proxy-buffers": "8 4k",
                "openresty.proxy-busy-buffer-size": "8k",
                "openresty.proxy-connect-timeout": "60s",
                "openresty.proxy-read-timeout": "60s",
                "openresty.proxy-send-timeout": "60s",
                "openresty.send-timeout": "60s",
                "openresty.underscore-in-headers": "off",
                "openresty.x-forwarded-for-value": "$remote_addr",
                "openresty.x-forwarded-port-value": "$server_port",
                "openresty.x-forwarded-proto-value": "$scheme",
                "org.label-schema.schema-version": "1.0",
                "org.label-schema.vendor": "dokku",
                "org.opencontainers.image.ref.name": "ubuntu",
                "org.opencontainers.image.version": "22.04"
            },
            "OnBuild": null,
            "OpenStdin": false,
            "StdinOnce": false,
            "Tty": false,
            "User": "herokuishuser",
            "Volumes": null,
            "WorkingDir": "/app"
        },
        "Created": "2024-09-23T10:38:57.264263409Z",
        "Driver": "overlay2",
        "ExecIDs": null,
        "GraphDriver": {
            "Data": {
                "LowerDir": "/var/lib/docker/overlay2/9888689d0f844af07d03f59dbe0935cf4cabf20ecd78889f9be4f7e0bb7f58ff-init/diff:/var/lib/docker/overlay2/pvfrtis2v9qkayo2rg537jdpb/diff:/var/lib/docker/overlay2/c09de0bsm7p7zl0t1ng4hselu/diff:/var/lib/docker/overlay2/juj972salgzgogett2mfojo84/diff:/var/lib/docker/overlay2/8c4233517f764f49b46d91e3e437fd436154bec053ca0369e5bfd509feeeadbe/diff:/var/lib/docker/overlay2/n3h7unxrn3nmpedd1fzl07gxv/diff:/var/lib/docker/overlay2/aw7rxjt66ehlniopsf90k5goy/diff:/var/lib/docker/overlay2/me1njnc0ojw1xnso55qeidqhl/diff:/var/lib/docker/overlay2/gmahj6w1iuil8fbd869nqaojx/diff:/var/lib/docker/overlay2/f11waoy2abv24qrut8ce4x0ou/diff:/var/lib/docker/overlay2/aa1b5618da1438fc67dfe8496999cc80b6e68f74971eee5abed264e24162b73e/diff:/var/lib/docker/overlay2/c9a4b68c60e72834843042202424f70966e222aa0d237d886c397769c82cbe83/diff:/var/lib/docker/overlay2/879056c5e6c7be5d85674e7d3c60052be587ebcb06a74f9a7a111bf870de3283/diff:/var/lib/docker/overlay2/8925c0a56afc726cbdfdc47262fd7f71b4be3ff56a3bd77d40241c7c1eb1d208/diff:/var/lib/docker/overlay2/97596a178253b1b62464881f9de15390b686147bddabf0cb7e68a6879be87b0d/diff:/var/lib/docker/overlay2/15a7bc3a6d892f13797f2aceeac1986ca3da2cb902d13d0ec74bea3c173336fe/diff:/var/lib/docker/overlay2/c5125531db5281b6b2689a6b71610b8e047df8b1092e918b80dfcd8754a5cc57/diff:/var/lib/docker/overlay2/1c47b1e096c09c424f329eb43cea4cfcd0c06f8591f79f7b8399b64b5357faaf/diff:/var/lib/docker/overlay2/98e4c5b7edf7bab0c74d4ccb4a19b34e49a52ae13ade7845686b6eec54dff6be/diff:/var/lib/docker/overlay2/7a7217f2a323496a2477ddb9f347f3746499052914dde5a1c280a8b5432197c4/diff",
                "MergedDir": "/var/lib/docker/overlay2/9888689d0f844af07d03f59dbe0935cf4cabf20ecd78889f9be4f7e0bb7f58ff/merged",
                "UpperDir": "/var/lib/docker/overlay2/9888689d0f844af07d03f59dbe0935cf4cabf20ecd78889f9be4f7e0bb7f58ff/diff",
                "WorkDir": "/var/lib/docker/overlay2/9888689d0f844af07d03f59dbe0935cf4cabf20ecd78889f9be4f7e0bb7f58ff/work"
            },
            "Name": "overlay2"
        },
        "HostConfig": {
            "AutoRemove": false,
            "Binds": null,
            "BlkioDeviceReadBps": [],
            "BlkioDeviceReadIOps": [],
            "BlkioDeviceWriteBps": [],
            "BlkioDeviceWriteIOps": [],
            "BlkioWeight": 0,
            "BlkioWeightDevice": [],
            "CapAdd": null,
            "CapDrop": null,
            "Cgroup": "",
            "CgroupParent": "",
            "CgroupnsMode": "private",
            "ConsoleSize": [
                0,
                0
            ],
            "ContainerIDFile": "",
            "CpuCount": 0,
            "CpuPercent": 0,
            "CpuPeriod": 0,
            "CpuQuota": 0,
            "CpuRealtimePeriod": 0,
            "CpuRealtimeRuntime": 0,
            "CpuShares": 0,
            "CpusetCpus": "",
            "CpusetMems": "",
            "DeviceCgroupRules": null,
            "DeviceRequests": null,
            "Devices": [],
            "Dns": [],
            "DnsOptions": [],
            "DnsSearch": [],
            "ExtraHosts": null,
            "GroupAdd": null,
            "IOMaximumBandwidth": 0,
            "IOMaximumIOps": 0,
            "Init": true,
            "IpcMode": "private",
            "Isolation": "",
            "Links": null,
            "LogConfig": {
                "Config": {
                    "max-size": "10m"
                },
                "Type": "json-file"
            },
            "MaskedPaths": [
                "/proc/asound",
                "/proc/acpi",
                "/proc/kcore",
                "/proc/keys",
                "/proc/latency_stats",
                "/proc/timer_list",
                "/proc/timer_stats",
                "/proc/sched_debug",
                "/proc/scsi",
                "/sys/firmware",
                "/sys/devices/virtual/powercap"
            ],
            "Memory": 0,
            "MemoryReservation": 0,
            "MemorySwap": 0,
            "MemorySwappiness": null,
            "NanoCpus": 0,
            "NetworkMode": "bridge",
            "OomKillDisable": null,
            "OomScoreAdj": 0,
            "PidMode": "",
            "PidsLimit": null,
            "PortBindings": {},
            "Privileged": false,
            "PublishAllPorts": false,
            "ReadonlyPaths": [
                "/proc/bus",
                "/proc/fs",
                "/proc/irq",
                "/proc/sys",
                "/proc/sysrq-trigger"
            ],
            "ReadonlyRootfs": false,
            "RestartPolicy": {
                "MaximumRetryCount": 10,
                "Name": "on-failure"
            },
            "Runtime": "runc",
            "SecurityOpt": null,
            "ShmSize": 67108864,
            "UTSMode": "",
            "Ulimits": [],
            "UsernsMode": "",
            "VolumeDriver": "",
            "VolumesFrom": null
        },
        "HostnamePath": "/var/lib/docker/containers/e1994e4131cf1fd2ec13e92f484f8b64bbf69e2d19172cf31fd3d0042c5ceb5f/hostname",
        "HostsPath": "/var/lib/docker/containers/e1994e4131cf1fd2ec13e92f484f8b64bbf69e2d19172cf31fd3d0042c5ceb5f/hosts",
        "Id": "e1994e4131cf1fd2ec13e92f484f8b64bbf69e2d19172cf31fd3d0042c5ceb5f",
        "Image": "sha256:19fc774caf7eb9ac745ecbbe31a957c5f8886971c2ebccd4dce358c8cfe46978",
        "LogPath": "/var/lib/docker/containers/e1994e4131cf1fd2ec13e92f484f8b64bbf69e2d19172cf31fd3d0042c5ceb5f/e1994e4131cf1fd2ec13e92f484f8b64bbf69e2d19172cf31fd3d0042c5ceb5f-json.log",
        "MountLabel": "",
        "Mounts": [],
        "Name": "/web.web.1",
        "NetworkSettings": {
            "Bridge": "",
            "EndpointID": "88cbf78acc11689958b2aa195a5b3d172f53d086ca04f1f9fded37a2684d0028",
            "Gateway": "172.17.0.1",
            "GlobalIPv6Address": "",
            "GlobalIPv6PrefixLen": 0,
            "HairpinMode": false,
            "IPAddress": "172.17.0.16",
            "IPPrefixLen": 16,
            "IPv6Gateway": "",
            "LinkLocalIPv6Address": "",
            "LinkLocalIPv6PrefixLen": 0,
            "MacAddress": "02:42:ac:11:00:10",
            "Networks": {
                "bridge": {
                    "Aliases": null,
                    "DNSNames": [
                        "web.web.1",
                        "e1994e4131cf"
                    ],
                    "DriverOpts": null,
                    "EndpointID": "88cbf78acc11689958b2aa195a5b3d172f53d086ca04f1f9fded37a2684d0028",
                    "Gateway": "172.17.0.1",
                    "GlobalIPv6Address": "",
                    "GlobalIPv6PrefixLen": 0,
                    "IPAMConfig": null,
                    "IPAddress": "172.17.0.16",
                    "IPPrefixLen": 16,
                    "IPv6Gateway": "",
                    "Links": null,
                    "MacAddress": "02:42:ac:11:00:10",
                    "NetworkID": "1e2154c303d9f900a5ea4f9915a340c6751c4d179fd03f00554a5478dae8d2a9"
                }
            },
            "Ports": {},
            "SandboxID": "6aa7008ceb5f2b60bf5d166d9440c5c2069df198bfaa123c0e212986cad4b9cb",
            "SandboxKey": "/var/run/docker/netns/6aa7008ceb5f",
            "SecondaryIPAddresses": null,
            "SecondaryIPv6Addresses": null
        },
        "Path": "/start",
        "Platform": "linux",
        "ProcessLabel": "",
        "ResolvConfPath": "/var/lib/docker/containers/e1994e4131cf1fd2ec13e92f484f8b64bbf69e2d19172cf31fd3d0042c5ceb5f/resolv.conf",
        "RestartCount": 0,
        "State": {
            "Dead": false,
            "Error": "",
            "ExitCode": 0,
            "FinishedAt": "0001-01-01T00:00:00Z",
            "OOMKilled": false,
            "Paused": false,
            "Pid": 772469,
            "Restarting": false,
            "Running": true,
            "StartedAt": "2024-09-23T10:38:57.775150764Z",
            "Status": "running"
        }
    }
]

job-logs.txt

josegonzalez commented 2 months ago

A few things:

The error message "Invalid IP address" is written to stderr and can be ignored. We can probably just silence it unless TRACE=1 or something. That code is here.
SendEnv only works if you allow the variable to be sent in your /etc/sshd_config file via an AcceptEnv directive. See this stackoverflow answer for more details.
Dokku will not automatically use passed environment variables as environment variables for your app. You would also need to somehow add that to the app via a custom plugin. That is outside the scope of this particular project, but we have docs on writing custom plugins.

I'll follow-up with silencing that error, but otherwise I hope the above helps.

Alin-Dumitrescu commented 2 months ago

See below

Thank you, Alin Dumitrescu Azure DevOps Consultant phone (425) 279-3465

From: Jose Diaz-Gonzalez @.> Sent: Monday, September 23, 2024 4:21 PM To: dokku/github-action @.> Cc: Alin Dumitrescu @.>; Author @.> Subject: Re: [dokku/github-action] Dokku push action does not update app variable. (Issue #88)

A few things:

The error message "Invalid IP address" is written to stderr and can be ignored. We can probably just silence it unless TRACE=1 or something. That code is herehttps://github.com/dokku/ci-docker-image/blob/50f9df45efa3e8b006095cbf70e959172dbbe879/bin/parse-ssh-host#L16. I think the code should not check for IP if the string is a valid FQDN.
SendEnv only works if you allow the variable to be sent in your /etc/sshd_config file via an AcceptEnv directive. See this stackoverflow answerhttps://serverfault.com/a/482909 for more details.
Dokku will not automatically use passed environment variables as environment variables for your app. You would also need to somehow add that to the app via a custom plugin. That is outside the scope of this particular project, but we have docshttps://dokku.com/docs/development/plugin-creation/ on writing custom plugins. Funny, MS copilot thinks this should work, so I assume there are some posts out there that suggest that(see screenshot below). What is the point to pass env variables via GIT_SSH_COMMAND, if you cannot use it on a new build? I was able to manually update the dokku var with a ssh call before the push, but it is not an elegant solution...

@. @.

I'll follow-up with silencing that error, but otherwise I hope the above helps.

— Reply to this email directly, view it on GitHubhttps://github.com/dokku/github-action/issues/88#issuecomment-2369298817, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AETLUKKEDY5XB6IP2RBGANTZYBZ4PAVCNFSM6AAAAABOV2HKMOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRZGI4TQOBRG4. You are receiving this because you authored the thread.Message ID: @.**@.>>

josegonzalez commented 2 months ago

It's a bit hard to read your response since it came from mail, but I'll respond as I understand it:

The warning that is printed is for debugging purposes. It is trying to detect if its an IP at all, and its warning that its not. The IPv6 detection must occur as we need to treat IPv6 hosts differently.
MS Copilot is hallucinating. The supposed functionality doesn't work, and is limited by both the fact that the environment variable isn't being accepted in the sshd_config and that Dokku wouldn't ever just set all of it's environment variables as variables for apps. Again, you'll need to change the sshd_config and build a plugin for what you want.
Customizing the GIT_SSH_COMMAND can be used to increase verbosity or set other options for the ssh call, such as when tunneling through a bastion server. However, just because you can set an env var in GIT_SSH_COMMAND, doesn't mean dokku will necessarily do anything with it (as mentioned before).

dokku / github-action