Closed tianhuil closed 2 years ago
Can you include the output of a deploy after enabling trace mode via dokku trace:on
?
Thanks for the quick response @josegonzalez: here it is: https://gist.github.com/tianhuil/7b9935bb9c372f50a825ac6642b4da0e
Oh I see what is going on. The post-extract
file is not executable, so it is being skipped. You need to do chmod +x
on it, commit that, upgrade the plugin, and then it should work.
Thanks so much @josegonzalez! Should have caught that one.
Does it make sense for dokku to warn if it encounters a non-executable file in an extension (with trace being off?). For example: "Encountered apparent hook file post-extract in extension dokku-docker-monorepo that was not executable and is ignored. Run chmod +x post-extract
to make it executable." It seems that if a hook file exists, the user probably intended that it should be run and it's not only because of an oversight.
I was thinking about this and have decided that while it would be useful, the proper place to log it would be in plugn
.
Description of problem
I wrote a Dokkku plugin here dokku-docker-monorepo which is based on dokku-monorepo. However, it isn't even being detected. I'm installing both the same way but dokku-monorepo is detected by dokku (and works correctly) while dokku-docker-monorepo is not. Am I missing something?
How reproducible
Follow the instructions at dokku-docker-monorepo and (dokku-monorepo) to compare.
Actual Results
I do not see "Docker Monorepo Plugin installed" printed to the screen.
Expected Results
I expect to see "Docker Monorepo Plugin installed" printed to the screen, which it should do unconditionally (see https://github.com/tianhuil/dokku-docker-monorepo/blob/main/post-extract).
Environment Information
dokku report APP_NAME
outputThe build fails and did not update the app so I don't think this is important.
How (deb/make/rpm) and where (AWS, VirtualBox, physical, etc.) was Dokku installed?:
Running on Digital Ocean:
Additional information