search

dokufreaks / plugin-blogtng

http://dokuwiki.org/plugin:blogtng
GNU General Public License v2.0
36 stars 18 forks source link

Does not send emails to blog author if comments_subscription is disabled #130

Open mthu opened 3 years ago

mthu commented 3 years ago

While send_subscriber_mails function contains a condition https://github.com/dokufreaks/plugin-blogtng/blob/52ff4f7d1a7023561a500861f7ee9be7dccd8f93/helper/comments.php#L269 which stops just after the notification to the author is sent (but not to the subscribers), it is not called from save (caller function) if subscription is disabled https://github.com/dokufreaks/plugin-blogtng/blob/52ff4f7d1a7023561a500861f7ee9be7dccd8f93/helper/comments.php#L177

This combination makes the case "send to the authors only" unavailable. It allows either all users to get subscribed, or nothing.

I guess this is not intended behavior, probably the send_subscriber_mails should be called in every case, independently on comments_subscription setting.