search

dokufreaks / plugin-discussion

Add a comments section to DokuWiki pages
https://www.dokuwiki.org/plugin:discussion
GNU General Public License v2.0
35 stars 28 forks source link

no button for the media manager #168

Open Juergen-aus-Zuendorf opened 9 years ago

Juergen-aus-Zuendorf commented 9 years ago

Hi,

in my wiki, the Discussion toolbar has no button for the media manager. How can it be activated?

Regards Juergen

Klap-in commented 9 years ago

It is removed in the code at the moment....: https://github.com/dokufreaks/plugin-discussion/blob/master/action.php#L157

Klap-in commented 9 years ago

Another plugin that is doing things with restricted syntax (and maybe toolbars) is https://github.com/dokufreaks/plugin-blogtng/blob/master/renderer/comment.php

Also relevant for blog, etc etc

Maybe useful to develop one solution for all.

Juergen-aus-Zuendorf commented 9 years ago

Do you know a reason why it is removed in the code?

You mention the blogtng plugin as a good alternative. I don't dare to use it because of the warning notice "ORPHANED ..."

Regards Juergen

michitux commented 9 years ago

The discussion plugin was developed as part of the blog plugin suite and thus designed to be used in a public blog. In that context uploading or embedding images does not make much sense.

Regarding discussion vs. blogtng: blogtng has no toolbar at all. It is just interesting in the sense that it properly restricts the syntax that is executed in comments such that e.g. not all plugins are allowed.

Concerning the maintenance status I would say that both plugins are both maintained and unmaintained at the same time. There is nobody really developing new features for any of them as far as I'm aware. At the same time there are some people like Klap-in, lupo49 and me who are occasionally fixing bugs. I personally rather like the old plugins like the discussion plugin and would rather continue them than blogtng but at the same time I'm actually using blogtng so for the time being I'll definitively fix blogtng if there should be anything seriously broken.

Juergen-aus-Zuendorf commented 9 years ago

Thank you very much for the details. I will see, what is the best way for us to implement.

Regards Juergen

GJRobert commented 7 years ago

Dear all, I found that the inline editing interface of plugin:fastwiki, is also affected when plugin:discussion is enabled (bug report to fastwiki). I wonder if there is a way not to affect other toolbars on the page when plugin:discussion handles the customization of buttons?

Klap-in commented 7 years ago

Maybe a workaround is to add a check that limit the simplification of the toolbar to only discussions. But on long term I guess a refactorizing of the toolbar code could be useful, such that it is easier to apply it to custom input fields of plugins.

https://github.com/dokufreaks/plugin-discussion/blob/master/action.php#L157