search

dokufreaks / plugin-discussion

Add a comments section to DokuWiki pages
https://www.dokuwiki.org/plugin:discussion
GNU General Public License v2.0
35 stars 26 forks source link

Discussion plugin changes main edit window toolbar, removes image and horizontal rule buttons #316

Open cjohnsonuk opened 3 years ago

cjohnsonuk commented 3 years ago

I'm running 2020-07-29 Hogfather with bootstrap v3 template. Logged in as administrator user I get different toolbars on different pages, Default long/complete toolbar

fulltoolbar Short toolbar that appears when editing any page with a ~~ DISCUSSION ~~ tag shorttoolbar

There are no errors in the console. Looking at other pages at the same level as the one with the short toolbar they all have the full toolbar except this one. Looking at the syntax within the page there is a ~~DISCUSSION~~ tag at the top of the page but not in the others. If I remove this tag or disable the discussion extension then I get the full toolbar. The Discussion plugin is the latest version as of the date of posting this message and is dated 2020-09-24

I need to have the full toolbar when editing the page with a discussion in so I can insert images and attach files without removing the discussion tag first.

Klap-in commented 3 years ago

The discussion plugin offers a shorter toolbar on purpose. I do not remember the reasoning behind this.

edit: this shorter toolbar should be only used in the comment field of the discussion plugin. Not in the default editing window.

cjohnsonuk commented 3 years ago

I'm guessing it's to stop you entering incompatible markup in the discussion itself but this is not the discussion box edit bar I'm talking about, it's the tool bar displayed when I edit the page with the discussion on. On my instance I get short toolbars on both.

cjohnsonuk commented 2 years ago

I've still got this issue. The reduced "discussion toolbar" is showing when I edit the whole page, not just for the just for the discussion entry box. I need to be able to insert images onto a page that has a discussion at the bottom of it without having to remove the discussion code, save the page and then re-edit, then save the page and re-edit to add the discussion back in again

Can someone confirm if this happens for others or just my installations?

cjohnsonuk commented 2 years ago

Any update on this appreciated Is this intended behaviour to limit the edit toolbar for the main page editor on a page that has a discussion. Its not just the discussion toolbar that is reduced, at least its not on my installation. Can anyone confirm if this happens for them too

Klap-in commented 2 years ago

I guess the check for when the modified toolbar should be offered has flaws..

cjohnsonuk commented 2 years ago

Gerrit Are you confirming that this happens for you too? I wasn't sure if it was just my installation/combination of other plugins...

Chris

Klap-in commented 2 years ago

I haven’t test it yet, I was guessing the possible cause, based on what I remember about its implementation.