search

dokufreaks / plugin-include

A DokuWiki plugin for including other wiki pages into the current one.
http://www.dokuwiki.org/plugin:include
GNU General Public License v2.0
62 stars 54 forks source link

Compatibility with new section editing in DokuWiki Greebo, fix #223 #224

Closed michitux closed 6 years ago

michitux commented 6 years ago

This is a basic compatibility fix. It would be nice if the edit button of the include plugin (for the whole included page) could also set the hid of the first header but this is not easily possible as that hid is not available globally (for this the code design would need to be changed). Further, the code block count won't be correct when multiple pages are included. This would probably need to be patched when the actual buttons are generated in the action plugin. For this, the actual code block count would need to be determined when scanning the instructions of the page to include (in particular when only a single section is included). I haven't implemented that yet and would move this to a new issue once this has been merged as I think basic compatibility is more important than correct code block counts.

lpaulsen93 commented 6 years ago

Although the question is if we merge this PR or rely on the workaround in the core?

michitux commented 6 years ago

The workaround in the core still triggers an error message, the changes in this PR are necessary to silence them - therefore I will merge them.

lpaulsen93 commented 6 years ago

:thumbsup: