search

dokufreaks / plugin-include

A DokuWiki plugin for including other wiki pages into the current one.
http://www.dokuwiki.org/plugin:include
GNU General Public License v2.0
62 stars 54 forks source link

severe bug with new dw with html code in plugin include #289

Closed zpartakov closed 1 year ago

zpartakov commented 1 year ago

on my blog https://radeff.red/blog/ I'm using the blog plugin, which requires the include plugin

after upgrade to dw 2023-04-04 "Jack Jackrum" I had the critical message:

TypeError: call_user_func_array(): Argument #1 ($callback) must be a valid callback, class Doku_Renderer_metadata does not have a method "html"

An unforeseen error has occured. This is most likely a bug somewhere. It might be a problem in the include plugin.

More info has been written to the DokuWiki error log.

Now, all the code surrounded by <html> ... code ... </html> is rendered as plain text

ksnip_20230407-155213

fiwswe commented 1 year ago

Not sure why you are raising this issue with the Include Plugin?

Note: <html> is no longer supported starting with DokuWiki "Jack Jackrum". See: Release Notes. You may want to consider using a plugin such as htmlok Plugin or Ad-Hog Tags Plugin if you are sure that you have mitigated the associated security risks.

zpartakov commented 1 year ago

thks so much fiwse - I wrote that because of the message saying "It might be a problem in the include plugin", I'll try your solution and return to this issue

zpartakov commented 1 year ago

once again thanks, the fix with plugin htmlok works perfectly, my blog is live again! hope this may be usefull to others

fiwswe commented 1 year ago

Yes, always read the release notes before upgrading anything ;-)