search

dokufreaks / plugin-include

A DokuWiki plugin for including other wiki pages into the current one.
http://www.dokuwiki.org/plugin:include
GNU General Public License v2.0
62 stars 54 forks source link

include-tagfilter-refactoring #296

Closed fjf2002 closed 1 year ago

fjf2002 commented 1 year ago

A bit of refactoring, hopefully done correctly.

Fixes #294.

Request for comments.

michitux commented 1 year ago

This seems to break the tests that are currently working (see your other pr) which is not good. I haven't checked why that happens but this indicates that something has been broken.

Apart from that, thank you very much, the include plugin's API can definitely use some refactoring to make it easier to use for other plugins. Note that the blog plugin already uses the include plugin to display blog posts.

fjf2002 commented 1 year ago

Thank You. Well, er, I draw back. For the tagfilter plugin I'll take the ...

$renderer->nest($includeHelper->_get_instructions(...))

... approach as used in the blog plugin. I just thought I would need the rest of the code in the render function somehow.