search

dokufreaks / plugin-meta

http://dokuwiki.org/plugin:meta
8 stars 7 forks source link

Fix and cleanup #10

Closed lpaulsen93 closed 2 years ago

lpaulsen93 commented 3 years ago

This fixes array operations and includes some code cleanup.

Klap-in commented 3 years ago

@lpaulsen93 looks good. You have test the changes?

lpaulsen93 commented 3 years ago

@Klap-in I did a short test and that seemed to work fine for me. But I don't use the plugin myself.

Klap-in commented 3 years ago

Should this address #9?

lpaulsen93 commented 3 years ago

Could be but I am not sure so I asked for testing in #9.

Klap-in commented 2 years ago

@lpaulsen93

The unit tests show these errors here (locally) (unit test are not enabled at github..)

Failed asserting that null matches expected 'bar'.
Expected :bar
Actual   :null
<Click to see difference>

 /../dokuwiki/lib/plugins/meta/_test/rendering.test.php:29

Failed asserting that two strings are equal.
Expected :'My abstract'
Actual   :'Persistent description'
<Click to see difference>

 /../dokuwiki/lib/plugins/meta/_test/rendering.test.php:45