search

dokun1 / Lumina

A camera designed in Swift for easily integrating CoreML models - as well as image streaming, QR/Barcode detection, and many other features
https://david.okun.io
MIT License
898 stars 91 forks source link

Iphone X support #71

Closed arvidurs closed 6 years ago

arvidurs commented 6 years ago

Please adjust the UI Buttons to respect the safemargins for iPhoneX.

Thanks

dokun1 commented 6 years ago

Hi @arvidurs! Thank you for reporting this issue.

Could you provide a little bit more information? Additionally, can you tell me if #69 did not fix this issue already?

I do not personally have an iPhone X, so I cannot test this myself. I think this means I need to build a version of this that works in the simulator so I can test the UI buttons around it, but please be a little more clear about what you are saying.

arvidurs commented 6 years ago

Hi David, sorry about not being more specific regarding the issue. I have checked #69 and they are still very very close to the borders. Just some padding left/right and from the top would help a lot. It might be a minor thing, but it's just something I thought to flag.

Thanks for the awesome framework btw!

dokun1 commented 6 years ago

Fair point. I'll take a look this week and see what I can come up with. In addition to meeting some friends who have these fancy new phones later this week, I'll work up some simulator support.

dokun1 commented 6 years ago

@arvidurs sorry I haven't gotten to it yet this week! Been a bit snowed under with other things coming down on me, but I can try to make a change sometime this week.

Of course, feel free to fork and take a swing at making some changes yourself if you'd like :-]