search

dokun1 / Lumina

A camera designed in Swift for easily integrating CoreML models - as well as image streaming, QR/Barcode detection, and many other features
https://david.okun.io
MIT License
899 stars 91 forks source link

.xcworkspace doesn't work on download #74

Closed dokun1 closed 6 years ago

dokun1 commented 6 years ago

When you clone the project, the workspace doesn't compile the sample app out of the box. In order to get this working on your machine, you currently need to:

  1. Clone the project.
  2. Open the .xcworkspace file.
  3. Delete the red-text framework file reference in the sample app folder "Frameworks".
  4. Build the framework scheme.
  5. Drag Lumina.framework from the built products directory in your framework project file to the sample project file.
  6. Go to the LuminaSample project file, and add Lumina.framework into Embedded Binaries.
  7. Run the LuminaSample app.

This works, and is normal to an extent for working with these kinds of projects, but it's not a happy path for those who want to try the framework for the first time.

It would be good if the .xcworkspace file worked out of the box when the project is cloned. I have experimented with two things:

  1. Changing the BUILT_PRODUCTS_DIR to something static that the sample project will recognize.
  2. Hardcoding the path to DerivedData where the built framework is placed.

Neither of these worked, or rather I couldn't figure them out.

Help?

dokun1 commented 6 years ago

Belated thank you to @nathangitter for reporting this issue!

dokun1 commented 6 years ago

Fixed by @gregheo