search

dokuwiki / dokuwiki

The DokuWiki Open Source Wiki Engine
http://www.dokuwiki.org
GNU General Public License v2.0
4.13k stars 849 forks source link

files present in source code are listed in 'deleted.files ' #4214

Open uvelokk opened 7 months ago

uvelokk commented 7 months ago

The problem

Some of the files which are listed in ./data/deleted.files are (still?) present in the source code:

Version of DokuWiki

2024-02-06a "Kaos"

PHP Version

8.2

Webserver and version of webserver

No response

Browser and version of browser, operating system running browser

No response

Additional environment information

No response

Relevant logs and/or error messages

No response

fiwswe commented 7 months ago

Did you follow the upgrade instructions including the Removing Unused Files step?

splitbrain commented 7 months ago

Confirmed.

https://github.com/dokuwiki/dokuwiki/blob/master/data/deleted.files#L59-L70

https://github.com/dokuwiki/dokuwiki/tree/master/vendor/paragonie/random_compat

Seems like we had this library at some point, then removed it in 2022, then it got readded as dependency when we updated to phpseclib3.

xrat commented 7 months ago

I'd appreciate a notice at the top of deleted.files that despite what it looks like at the top (right now) lines had actually been removed since 2022-06-26. That is for now and until #4217 gets resolved.

splitbrain commented 7 months ago

@xrat I'm not sure I understand what you're asking for. Feel free to provide a PR.

xrat commented 7 months ago

I meant that any changes made to deleted.files should be documented within the file itself. But since my last comment I figured it's not really a problem. I just need to change my workflow when upgrading: I need to remove files listed in deleted.files first, and only then do the upgrade.

xrat commented 7 months ago

Looking at my upgrade procedure like I have done it for way more than a decade ;) I see I always deleted first and unpacked afterwards. However, upgrade instructions in the wiki actually suggest a different order:

Step 4: Unpack the distribution tarball and upload/copy the files over your previous installation. (…)
Step 5: Delete all unused files

quinox commented 1 month ago

What's the state of the random_compat lib right now? The data/deleted.files removes all the files from the old version (fine), but with 927933f the lib was partially added again which added one file that's (1) empty and (2) not listed in the data/deleted.files: vendor/paragonie/random_compat/lib/random.php. Since it's not part of data/deleted.files my script isn't deleting it, but it also appears to be unnecessary.