search

dokuwiki / translate.dokuwiki.org

Web based tool to create and update translation patches for DokuWiki and DokuWiki plugins.
MIT License
8 stars 2 forks source link

Some issues #81

Closed Klap-in closed 8 years ago

Klap-in commented 9 years ago

Many most small changes. Please see the separate commits.

Klap-in commented 8 years ago

A lot of different changes are included in this pull request. I will continue in a new PR for additional set of changes. Review welcome.

splitbrain commented 8 years ago

I went through all commits. Looks awesome. Merging it.

splitbrain commented 8 years ago

Ahh I was too fast. 03f4b01 caused a problem because there seems to be column missing:

Column not found: 1054 Unknown column 'r1_.englishReadonly' in 'field list'

I think there should be a migration for that?

for now I reverted that one commit on live

Klap-in commented 8 years ago

Symfony should perform the migration using the changed entity, it doesn't?

Some steps for performing an update are here mentioned: https://www.dokuwiki.org/teams:translate-tool#update Did you do something different?

I added another commit to master, which reverts a small change in a query function.

splitbrain commented 8 years ago

Hmm it said doctrine:schema:update should not be run in production. But it seems to have worked with --force anyway