dolbyio-samples / rts-app-react-publisher-viewer

A Real Time Streaming App example for dolby.io
MIT License
15 stars 9 forks source link

feat: multisource support in publisher #236

Closed jackshen closed 1 year ago

jackshen commented 1 year ago

Issue: https://github.com/dolbyio-samples/rts-app-react-publisher-viewer/issues/147

Description

In this PR, you can:

Code changes

vishalkharge commented 1 year ago

@jackshen

Here are some basic functional issues observed on this PR:

  1. There is no way to close the screen share view or additional camera view
  2. For screen share view, resolution setting dropdown has undefined value
  3. For camera view, microphone and camera toggle buttons are missing
  4. For screen view, close/stop toggle buttons are missing
  5. Error message 'Failed to execute 'setRemoteDescription' on 'RTCPeerConnection': Failed to set remote answer sdp: Called in wrong state: stable' is shown when publisher goes live.
jackshen commented 1 year ago

@jackshen

Here are some basic functional issues observed on this PR:

  1. There is no way to close the screen share view or additional camera view

  2. For screen view, close/stop toggle buttons are missing

1 and 4 will be handled in https://github.com/dolbyio-samples/rts-app-react-publisher-viewer/issues/195