dolejska-daniel / riot-api-league

GNU General Public License v3.0
15 stars 18 forks source link

add missing match fields #18

Open chypriote opened 1 year ago

chypriote commented 1 year ago

Hello, thanks for the recent update, glad to see you are still working on this project.

Using the match v5 api led into an error caused by some fields existing in the API that were not defined in the ParticipantDto class. Turns out it's something missing in the Riot documentation. This PR fixes it.

As a side note, those undefined fields trigger an error when trying to build the Dto (RiotAPI\Base\Objects\ApiObject::90). I believe it would be better if the Dto was still instantiated without the missing fields instead of failing. Looking at the linked PR, it seems that riot is regularly adding new fields, which would cause the Dto instantiation to fail each time