[Issue] Nicknames with spaces

initred commented 3 years ago

I am Korean and I have confirmed that there is a space in the nickname for the Korean region. Therefore, the spaces between nicknames should not be removed.

https://www.op.gg/summoner/userName=%EC%95%84+%EB%AC%98

See the site above.

dolejska-daniel commented 3 years ago

Hello, thank you for the PR! You are indeed correct. I have tested:

GET https://kr.api.riotgames.com/lol/summoner/v4/summoners/by-name/%EC%95%84%EB%AC%98

{
    "status": {
        "message": "Data not found - summoner not found",
        "status_code": 404
    }
}

While with the space in the name:

GET https://kr.api.riotgames.com/lol/summoner/v4/summoners/by-name/%EC%95%84%20%EB%AC%98

{
    "id": "0oKF5xMryreVZqur3uZbUjAF5ZEun5IPCGjbkCWKwpRKyw",
    "accountId": "lMD0OADPCsN6nRKkdqPulZLO64czVC-IQFwVBFnnIWID",
    "puuid": "JXXSRTIRGCgp_k7tgzh8oetNny_EWxPL9F5ymWxKl56bcv8in025A796Anqe9EyvHeH0E0Bs-ml1xg",
    "name": "아 묘",
    "profileIconId": 4573,
    "revisionDate": 1621788602610,
    "summonerLevel": 247
}

initred commented 3 years ago

Thank U for your hard work. Daniel. Good luck!

initred commented 3 years ago

If there is a request, I would like it to be applied to other related packages.

The PR was applied only to the master. I hope you add a tag. Add 1.0.2 Plz.

ex) dolejska-daniel / riot-api

dolejska-daniel commented 3 years ago

I've made a mistake when creating new Match v5 endpoints and committed them right into master.. I can only release this after Match v5 will be ready.. Sorry!

initred commented 3 years ago

I hope V5 comes out soon. Thank you always for your hard work ♥

dolejska-daniel / riot-api-league

[Issue] Nicknames with spaces #5