dolejska-daniel / riot-api

Riot League of Legends & DataDragon API wrappers for PHP7 and PHP8.
GNU General Public License v3.0
113 stars 25 forks source link

Data Dragon Update #20

Closed boraguler closed 5 years ago

boraguler commented 5 years ago

I'm newbie on RIOT API, just got your beautiful work and started to work with it, thank you very much.

About Data Dragon, seems Riot cut off static api, now API returns "Request: Forbidden. (Forbidden)" messages for most Data Dragon calls.

Will you be able to update soon?

dolejska-daniel commented 5 years ago

Hello and thank you for using this library 😃 I hope it works well for you.

I will try to implement workaround for StaticData deprecation for both DD & RiotAPI ASAP. I guess I will manage this week. We will see 😆... I will let you know when I do anyways. 😸

boraguler commented 5 years ago

Thank you very much.

By the way, I'm using a shared hosting. I had to add new doctrine/inflector version in composer manually, since it was giving errors when I uploaded to live. Just a reminder. /cheers

Edit: to be more specific, on similar lines such as "public function setSetting( string $name, $value ): self" and so on.

dolejska-daniel commented 5 years ago

Hey @boraguler,

what exactly does not work on DD API for you? I think that DD API went without changes during StaticData deprecation.. 🤔

boraguler commented 5 years ago

for ex. when i try the same with your example on here

or simply $api->getStaticChampion(61, null, null, 'all');

dolejska-daniel commented 5 years ago

Okay -- that is actually not problem of DataDragon API itself, that is a problem of RiotAPI (due to StaticData endpoint deprecation).

TheKeymaster commented 5 years ago

@dolejska-daniel is the static Data Dragon already included in the most recent version? If yes could you tell me the method name to get all Champions from the Data Dragon?

Thanks!

dolejska-daniel commented 5 years ago

@TheKeymaster It's not there yet, I'll try to look into it today. I'm currently quite busy with my Bachelor's thesis and other school projects :weary:. I'm sorry it's taking this long.

TheKeymaster commented 5 years ago

@dolejska-daniel thanks for your quick response and fix! Just for your information; I can't get the latest version from packagist. I need to use composer require dev-master to get the latest version. Could you create a new version on packagist as well? That would be great!

dolejska-daniel commented 5 years ago

@TheKeymaster The static-data are only available through DataDragon not RiotAPI itself. This has to be done explicitly so static-data objects can be created by RiotAPI and I did not have time for that just yet.

dolejska-daniel commented 5 years ago

I've created release v2.0.1 anyways 😆. Just for you 😎.

TheKeymaster commented 5 years ago

Thank you!!

regiszanandrea commented 5 years ago

Hey @dolejska-daniel ,

There will be a new version of this library for Riot API v4?

Thanks

dolejska-daniel commented 5 years ago

Hi @regiszanandrea,

I haven't looked into that just yet - so I do not know the number of differences between these versions. What do you mean by "will there be a new version"? As if I bring this library up-to date? If this is the question then probably yes.

...thought to get some help would be awesome, since I am working on my Bachelor's Thesis :smile_cat:.

regiszanandrea commented 5 years ago

Yeah, if you bring this library up-to date.

This is the official announcement: https://discussion.developer.riotgames.com/articles/6579/player-universally-unique-identifiers-and-a-new-se.html

I could help in developing something, because I'm using this library every day in a project. So if you need something you can email me at regiszanandrea@gmail.com

dolejska-daniel commented 5 years ago

I will do my best and I'll try to update it but I cannot tell you when I'll have enough time for it right now.

dolejska-daniel commented 5 years ago

Hey guys, I am quite pleased to tell you, that StaticData calls are once more available through RiotAPI!

dolejska-daniel commented 5 years ago

@boraguler @TheKeymaster @regiszanandrea, I'll close this issue since it is solved by new v3.0.0-rc.1 release. Please make sure to check out important changes in v3 so you don't have hard time updating 😼.

Any feedback is well appreciated! 😺