search

dolejska-daniel / riot-api

Riot League of Legends & DataDragon API wrappers for PHP7 and PHP8.
GNU General Public License v3.0
113 stars 25 forks source link

Support for RiotApi v4 #24

Closed regiszanandrea closed 5 years ago

regiszanandrea commented 5 years ago

Is your feature request related to a problem? Please describe. The Riot Developers announced that v3 API will be deprecated soon.

Describe the solution you'd like Today, they made available the endpoints from the new API version, v4. In the link below, there are the endpoints that needed to be implemented:

https://developer.riotgames.com/api-methods/

boraguler commented 5 years ago

I'm waiting for it too, can help you with it Daniel if needed.

dolejska-daniel commented 5 years ago

Hi guys,

there will be only minor adjustments to match v4 endpoint call changes. Thought there would be things I'd be grateful to get helped with -- I'll let you know soon 😆.

dolejska-daniel commented 5 years ago

So... I know that noone likes to write tests (#26) - BUT it needs to be done. And if you could help, that would be awesome!

There are also some things to be done to bridge StaticData calls from RiotAPI to DataDragonAPI (#25). But these are not that important.

dolejska-daniel commented 5 years ago

In the end, I wll manage to fix the tests by myself.

25 should be priority now.

dolejska-daniel commented 5 years ago

@regiszanandrea, @boraguler library should support v4 endpoints now! Please test it 😸. Note that Champion Mastery endpoint is not working correctly yet (Serivce unavailable).

Also, the tests should be kind of working again. But definitely are not complete. So any additions are welcome.

regiszanandrea commented 5 years ago

@dolejska-daniel Working as Designed.

Thank you so much ❤️

regiszanandrea commented 5 years ago

Hey @dolejska-daniel, I'll create a new issue for Tournament V4 Support, it's ok?

dolejska-daniel commented 5 years ago

@regiszanandrea sure is! Didn't hear anything about Tournament v4 😮

regiszanandrea commented 5 years ago

@dolejska-daniel I think the only thing that will change is in the tournament code creation, passing the encrypted summonerId

dolejska-daniel commented 5 years ago

Hey guys! Champion Mastery v4 and Tournament Stub v4 are up and running on a58847ca04b3a4e31ee6a036046f1608fe4dfeed 😼.

regiszanandrea commented 5 years ago

@dolejska-daniel Tournament v4 is available :)

dolejska-daniel commented 5 years ago

All v4 endpoints should be working on v3.0.0-alpha. Static data through RiotAPI still not implemented.

regiszanandrea commented 5 years ago

@dolejska-daniel Love you ❤️