search

dolejska-daniel / riot-api

Riot League of Legends & DataDragon API wrappers for PHP7 and PHP8.
GNU General Public License v3.0
113 stars 25 forks source link

Access var in LeagueItemDto #42

Closed maxiz22 closed 5 years ago

maxiz22 commented 5 years ago

Describe the bug Access var in LeagueItemDto class. Please change $summonerId and $summonerName to public in RiotAPI.

namespace RiotAPI\LeagueAPI\Objects;
class LeagueItemDto extends ApiObject {
    /** @var string $summonerId */
    public $summonerId;

    /** @var string $summonerName */
    public $summonerName;
}

I offer myself as a contributor for this proyect , it's genial Regards!

dolejska-daniel commented 5 years ago

Hello and thanks for the report @maxiz22! The object properties are not yet in the official API docs, so it wasn't updated as it should have been when I processed the documentation so I added them manually 😸.

Also huge thanks for the thumbs up ❤️! I'm pleased you like the library 😺.