dolejska-daniel / riot-api

Riot League of Legends & DataDragon API wrappers for PHP7 and PHP8.
GNU General Public License v3.0
112 stars 25 forks source link

Third party code endpoint returns 404 not found. #84

Closed exzib closed 3 years ago

exzib commented 4 years ago

Code to reproduce:

    public function getCode($region, $summoner_id) {
      $region_finder = new Region();
      $api = new LeagueAPI([
        LeagueAPI::SET_KEY    => $this->riotKey,
        //  Target region (you can change it during lifetime of the library instance)
        LeagueAPI::SET_REGION => $region_finder->getRegionName($region),
      ]);

      $code = $api->getThirdPartyCodeBySummonerId($summoner_id);

      dd($code);
    }
dolejska-daniel commented 4 years ago

That actually shouldn't be problem of the library itself, this endpoint is still proving to be unreliable and quite broken most of the time - even when client reports that third party code has been successfully saved, it is quite often impossible to retreive the code through the API.

Please check output at official developer portal.

dolejska-daniel commented 3 years ago

I'm closing the issue since it has been inactive for a long time.