search

dolejska-daniel / riot-api

Riot League of Legends & DataDragon API wrappers for PHP7 and PHP8.
GNU General Public License v3.0
112 stars 25 forks source link

PHP 8 Support #93

Closed blood72 closed 1 year ago

blood72 commented 3 years ago

Is your feature request related to a problem? Please describe. The PHP 8 has been released.

Describe the solution you'd like Is there any plan to support PHP 8? I just want to check that you have a plan. Then, I can wait for an upgrade until this is ready.

dolejska-daniel commented 3 years ago

Yes I surely want to support PHP8. I haven't looked into the incompatibilities just yet, will do soon!

TheMY3 commented 1 year ago

@dolejska-daniel now only need to update dependencies in this repo? Base repository now v2.0.0 with 8.1 support

dolejska-daniel commented 1 year ago

@dolejska-daniel now only need to update dependencies in this repo? Base repository now v2.0.0 with 8.1 support

https://github.com/dolejska-daniel/riot-api-league needs to be updated first. I am working on it though there are some issues with tests not going through. (https://github.com/dolejska-daniel/riot-api-league/pull/12)

TheMY3 commented 1 year ago

@dolejska-daniel can not see error logs in https://github.com/dolejska-daniel/riot-api-league/pull/12 and can not help with it :disappointed: waiting for fix, thanks for this)

dolejska-daniel commented 1 year ago

LeagueAPI v2 is now available: https://github.com/dolejska-daniel/riot-api-league/releases/tag/v2.0.0. I shall now update this metarepo with its latest version constraint. Nevertheless, this set of libraries desperately needs a new, at least partially skilled and interested maintainer to keep it going. I find myself without time to spend towards this, and since I do not play the game anymore either, there is 0 motivation to do so in the small amount of free time I have.

dolejska-daniel commented 1 year ago

https://github.com/dolejska-daniel/riot-api/releases/tag/v5.0.0

TheMY3 commented 1 year ago

LeagueAPI v2 is now available: dolejska-daniel/riot-api-league@v2.0.0 (release). I shall now update this metarepo with its latest version constraint. Nevertheless, this set of libraries desperately needs a new, at least partially skilled and interested maintainer to keep it going. I find myself without time to spend towards this, and since I do not play the game anymore either, there is 0 motivation to do so in the small amount of free time I have.

Thanks a lot, I have no free time too, but maybe I can help with it somethimes. I use this package for one project that used API for LoL, Valorant, TFT. So I interested at least in its support of current versions of PHP