search

dolevshor / azure-orphan-resources

Centralize orphan resources in Azure environments
MIT License
523 stars 135 forks source link

Subnets not showing in workbook #28

Closed letmetechyou closed 7 months ago

letmetechyou commented 7 months ago

The workbook shows the amount of subnets with no resources but does not list them out.

dolevshor commented 7 months ago

Hi @letmetechyou,

Can you please attach a screenshot?

As you can see below, it works as expected: image

letmetechyou commented 7 months ago

Does this take into account that subnets could be vnet injected by an app service but will not necessarily show connected devices.

Get Outlook for iOShttps://aka.ms/o0ukef

From: Dolev Shor @.> Sent: Thursday, January 25, 2024 3:04:44 AM To: dolevshor/azure-orphan-resources @.> Cc: Kevin Sims @.>; Mention @.> Subject: Re: [dolevshor/azure-orphan-resources] Subnets not showing in workbook (Issue #28)

Hi @letmetechyouhttps://github.com/letmetechyou,

Can you please attach a screenshot?

As you can see below, it works as expected: image.png (view on web)https://github.com/dolevshor/azure-orphan-resources/assets/69309933/85529fa3-0d95-40b3-ab9e-92d5fc378810

— Reply to this email directly, view it on GitHubhttps://github.com/dolevshor/azure-orphan-resources/issues/28#issuecomment-1909594706, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AMLWR3IPG2QF6ZM7N2JN5OLYQIGZZAVCNFSM6AAAAABCI4XN4KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBZGU4TINZQGY. You are receiving this because you were mentioned.Message ID: @.***>

dolevshor commented 7 months ago

Hi @letmetechyou ,

Thank you for bringing this distinction to my attention, it's a very good feedback. The term is subnet delegation - when a PaaS service injected into a subnet in a Virtual network.

Indeed, I did not refer to this when writing the query, so it also displayed subnets without connected device but with delegation. (for example: App Service VNet integration)

I already fixed that it in the query and in the workbook too.