dolevshor / azure-orphan-resources

Centralize orphan resources in Azure environments
MIT License
523 stars 135 forks source link

Add bicep and CI workflow #3

Open jbpaux opened 2 years ago

jbpaux commented 2 years ago

Hi, I love your workbook. In order to simplify the evolution of your workbook I suggest the following:

Since the Bicep Azure Action is not compatible with spaces in the file names I took the liberty of removing them (and I did a PR to the action to handle that in the future)

jbpaux commented 2 years ago

if you can have a look @dolevshor 😉

yaya2devops commented 1 year ago

That's great! @jbpaux

dolevshor commented 1 year ago

Hi @jbpaux, First, thank a lot for your PR and my apologies for responding only now. I would love to add your 'bicep and CI workflow' part, I can't merge it now because number of changes. I will make sure to include it in the next version that will be updated soon.

jbpaux commented 1 year ago

Hi, I've rebased to include your latest changes. It should be good to merge now !

jbpaux commented 1 year ago

@dolevshor I have re-rebased to include your latest changes. Feel free to merge it when you want

LuisFinOps commented 5 months ago

Hi @dolevshor, Your Workbook is very useful, so great job!!!. I´m just new overhere, so looking into your workbook, I figure out as an idea, if is it possible to include the following below new properties to these dashboards with the aim to give more cost visibility and provide value from FinOps management perspective.

Therefore, I´ve saw within this MS AZ public workbook "Azure | Home | Advisor | Workbooks | Gallery Cost | Optimization (Preview)" that it is possible to customize it, so looking into "advisorresources" tables under the following path "HOME>AZURE RESOURCE GRAPH EXPLORER>TABLE>advisorresources" url: "https://learn.microsoft.com/en-us/azure/cost-management-billing/finops/cost-optimization-workbook"), I´ve found these properties that I think will be useful to include it just to provide more inventory tracking and cost granularity view, to show to each Engineering Team what are the Acumulated Costs Impact of each idle resources and takes asap responsability on its optimizations.

I´m not a AZ technical expert, just a FinOps practitioner, so these are the following properties that I beleive from my point of view could be nice to include it on your Workbook:

Tables:

Fyi, I´m not a native english speaker, so apologize for any grammatical mistake and I hopes that this provide more value to this workbook.