dolevshor / azure-orphan-resources

Centralize orphan resources in Azure environments
MIT License
523 stars 135 forks source link

Overview is empty #39

Closed francesco1119 closed 4 months ago

francesco1119 commented 4 months ago

I was testing your code and I realized that the Overview of each resource is always empty:

image

All other fields (Activity Log, Access Control, Tags, etc...) are all populated.

dolevshor commented 4 months ago

Hi @francesco1119, First, thank you very much for paying attention to the issue.

TLDR; I will investigate the issue to understand if it is a bug or something that can be fixed in the display setting and update..

I checked it:

gardnerjr commented 4 months ago

@dolevshor It happens anywhere that a react view is used inside a menu blade inside a context pane, not specific to workbooks itself. some views are now using react for overviews, so you'll see it right away. in msazure see Feature 26147029: Allow resource menu blades to be opened in context panes (they currently work EXCEPT ReactViews!)

in my local copy of the workbook i changed every place that opens a resource blade as a context pane to not do that. (we also have a bug/feature request on the portal to let us tell the portal to open in new tabs/etc when we open blades, but they haven't done that yet, see Feature 17175696: [PartnerAsk][Workbooks] Enable ability for openBlade api to open blades in a new tab (or enable ctrl down = new tab from anyone calling openBlade?).

(FYI i'm the EM for workbooks team, found this workbook today cleaning up for wave 1 work, is awesome!)

dolevshor commented 4 months ago

Hi @francesco1119 ,

Happy to update that changed all views that utilize a "context pane to the side" to instead display as "full view". @gardnerjr Thank you for your involvement and comprehensive explanation of the issue.

You are welcome to update the version of the workbook and thanks again for paying attention to that.