dolezsa / thermal_comfort

Thermal Comfort sensor for HA (absolute humidity, heat index, dew point, thermal perception)
Other
601 stars 117 forks source link

Feature: support for a pressure sensor #2

Open johnboiles opened 5 years ago

johnboiles commented 5 years ago

Reading the code, I assume that a fixed value is used for pressure as an approximation. It might be nice to be able to pass in a pressure value from an atmospheric pressure sensor to make these values more accurate.

johnboiles commented 5 years ago

Looks like this is the place 1 atm is assumed for pressure. Though maybe variance here would affect the resulting output so little that it's not worth considering.

rautesamtr commented 2 years ago

Hey @johnboiles i think this would be a nice addition. Even tough you are right that it probably wouldn't change the results in most cases (I'd guess about 0,01°C at most). It would be still optional and would be nice to know my air pressure sensors would at least have some job to do.

bjeanes commented 2 years ago

People do live at different altitudes though, so while the day-to-day variation may be low, even allowing for a statistically configured pressure (but might as well be a sensor input at that point) might yield meaningful differences in sensor readings for those people. (I'm not one of those people btw -- I am at about .99 atm most of the time hah)

Migsi commented 1 year ago

I second this, especially as the new Aquara sensors seem to support pressure readings as well. Looking at the code and the linked calculation method, it will be necessary to add a second calculation code path instead of adjusting the existing one, as both calculation methods differ too much.