search

dolezsa / thermal_comfort

Thermal Comfort sensor for HA (absolute humidity, heat index, dew point, thermal perception)
Other
623 stars 119 forks source link

Computed sensor does not become unavailable, when the underlying real sensor becomes unavailable. #345

Open darrenfreeman opened 11 months ago

darrenfreeman commented 11 months ago

I have some ZigBee temperature/humidity sensors that are on vehicles, and so they become unavailable fairly often. Unfortunately, when this happens, the heat index and the dew point continue to report valid states. (I assume the other computed values would behave similarly.)

This can be problematic when using the value in an automation, for example running an air-conditioner until a room becomes very cold.

darrenfreeman commented 11 months ago

Another downstream problem caused by this - when combining the values in e.g. max/min helpers, they completely screw up the behaviour of the helper, when some sensors are unavailable.

rautesamtr commented 11 months ago

Sure we could make them unavailable when the state of input sensors is unknown over unavailable. If we do this we probably should also show a notification in the UI so the user knows why this happens.

@dolezsa what do you think?

darrenfreeman commented 11 months ago

I don't think a notification is the correct behaviour, none of the core helpers do this.

Also, all sensors are unavailable during HA startup. If the user wanted a notification, they should be looking at the integration that provides the physical sensor, as Thermal Comfort can't tell the reason why the sensor is unavailable.

dolezsa commented 11 months ago

Of course, I agree with you, rautesamtr, this is more than logical. :+1:

dolezsa commented 11 months ago

I was wondering that the notification might be reasonable in a way that the sensor value would indeed be 'unavailable,' but we would communicate the reason in an attribute, for example, that the temperature sensor is not accessible...

darrenfreeman commented 10 months ago

I'm looking forward to testing a fix, I have sensors coming and going all the time. The good news is I think it does go unavailable, if you fully restart HA.