Closed rautesamtr closed 2 years ago
sooner or later we will have to make this change, and from my point of view, especially if it is possible, as you write, with support both types, it would be best to do it so as soon as possible. also the possibility of configuration via ui would be nice to have imho.
There's one thing I'd personally like to break but is probably not the most welcome change. Imho it would be nice if we could change the sensor name from singlewords
to seperate_words
. e.g. This would make them more readable easier to convert to other strings. For example one could easily generate the default friendly name of the sensor type. And if we do this we could take another look at the string for the perception
sensor type. Which could be changed to thermal_perception
.
This could also be implemented with a mapper that accepts the old strings to keep everything backward compatible for now.
it would be best to do it so as soon as possible. also the possibility of configuration via ui would be nice to have imho.
Sounds good. We probably should add both in the same release cycle since the both build on common stuff that needs to be added. @IATkachenko has already done a lot of the frontend stuff in #86 and with a bit of polish it should be a good foundation to build upon.
So basically having both on the next feature release would offer users the choice to either migrate to the frontend config, new yaml config or stick with their old config.
just do it
Since there's Architecture Decision Record ADR0007 for home assistant this means the current configuration used in thermal comfort is considered legacy yaml configuration. So it would make sense to have a non configuration at some point. This can be done in a non breaking way supporting both configuration types. The old configuration will be supported as minimum till the next breaking version or even longer should maintenance stay at a minimum. See home assistants template integration for a partial migration to the new yaml configuration style. Or this work in progress PR https://github.com/home-assistant/core/pull/63840 for the command line integration.
Biggest differences would be:
sensors:
element we can have multiplesensor
elements.name
instead of being an implicit parent key.Are there any suggestions, questions or objections?
If there's any idea/reason for a breaking change of the configuration this would be the best time since both old and new configuration can coexist so it would be possible to implement breaking changes just in the new configuration type.