Implement guild member support

dolfies / discord.py-self

A fork of the popular discord.py for user accounts.

https://discordpy-self.rtfd.io/en/latest/

MIT License

684 stars 162 forks source link

Implement guild member support #224

Closed dolfies closed 2 years ago

dolfies commented 2 years ago

Summary

Implements initial guild member support.
Requires heavy testing.
Channel choosing logic is not perfect yet.

Checklist

[ ] If code changes were made then they have been tested.
- [ ] I have updated the documentation to reflect the changes.
[x] This PR fixes an issue.
[x] This PR adds something new (e.g. new method or parameters).
[x] This PR is a breaking change (e.g. methods or parameters removed/renamed)
[ ] This PR is not a code change (e.g. documentation, README, ...)

TheOnlyWayUp commented 2 years ago

LGTM, Thanks for all the work Dolfies :)

dolfies commented 2 years ago

So turns out I completely fucked up on the index side. This will... Require some work.

TheOnlyWayUp commented 2 years ago

So turns out I completely fucked up on the index side. This will... Require some work.

Says this after writing 600 lines of code, have fun 😬 (I sure will once the feature is out :P)

Info: Also, what parts are fucked?

dolfies commented 2 years ago

Code looks good, why were the exceptions changed to start with lower-case letters now?

They're caught and used when raising the ClientException.

dolfies commented 2 years ago

So turns out I completely fucked up on the index side. This will... Require some work.

Says this after writing 600 lines of code, have fun 😬 (I sure will once the feature is out :P)

Info: Also, what parts are fucked?

The indexing. Honestly don't know how I ever thought it would work. It's working now, though.